This is an archive of the discontinued LLVM Phabricator instance.

Fix an issue test suite handling of absolute paths on Windows
ClosedPublic

Authored by zturner on Oct 14 2014, 12:38 PM.

Download Raw Diff

Details

Reviewers

Summary

The test suite tries to create a log file name by taking the path of an executable and replacing slashes. This ignores the fact that it might contain a : on windows, which is an invalid filename character, and also doesn't use a platform-agnostic path separator.

Diff Detail

Event Timeline

zturner updated this revision to Diff 14879.Oct 14 2014, 12:38 PM

zturner retitled this revision from to Fix an issue test suite handling of absolute paths on Windows.

zturner updated this object.

zturner edited the test plan for this revision. (Show Details)

zturner added a subscriber: Unknown Object (MLST).

LGTM.

zturner accepted this revision.Oct 30 2014, 12:54 PM

zturner added a reviewer: zturner.

This revision is now accepted and ready to land.Oct 30 2014, 12:54 PM

This has been submitted.

Revision Contents

Path

Size

test/

lldbtest.py

6 lines

Diff 14879

test/lldbtest.py

Context not available.
	os.environ["LLDB_SESSION_DIRNAME"])	os.environ["LLDB_SESSION_DIRNAME"])
	if not os.path.isdir(dname):	if not os.path.isdir(dname):
	os.mkdir(dname)	os.mkdir(dname)
	fname = os.path.join(dname, "%s-%s-%s-%s.log" % (prefix, self.getArchitecture(), "_".join(self.getCompiler().split('/')), self.id()))	compiler = self.getCompiler()
		if compiler[1] == ':':
		compiler = compiler[2:]

		fname = os.path.join(dname, "%s-%s-%s-%s.log" % (prefix, self.getArchitecture(), "_".join(compiler.split(os.path.sep)), self.id()))
	with open(fname, "w") as f:	with open(fname, "w") as f:
	import datetime	import datetime
	print >> f, "Session info generated @", datetime.datetime.now().ctime()	print >> f, "Session info generated @", datetime.datetime.now().ctime()
Context not available.