Page MenuHomePhabricator

[clang-tidy] Fixed a std::bind() transformation
ClosedPublic

Authored by oleg.smolsky on Feb 5 2019, 10:56 AM.

Details

Summary

There was an extra semicolon that was somehow working in some contexts.

Diff Detail

Event Timeline

oleg.smolsky created this revision.Feb 5 2019, 10:56 AM
JonasToth accepted this revision.Feb 5 2019, 10:57 AM

LGTM, was there a bug report for that issue?

This revision is now accepted and ready to land.Feb 5 2019, 10:57 AM

:) I thought it would be more productive to post a fix than file a bug.

Definitly! I just asked because it would be better to mention it in the message ;)
Do you have commit rights?

Jonas, could you commit the fix please? (I don't have the rights)

@oleg.smolsky I can commit for you. Please note, that LLVM changed its license recently and this patch will land under the new license.
Please confirm that this is ok for you (more info on the license see https://llvm.org/docs/DeveloperPolicy.html#relicensing). I will wait so long :)

Sure, I'm OK with the license change. Please go ahead and commit the fix.

Landed in rL353389. Thank you for the patch!

JonasToth closed this revision.Feb 7 2019, 3:02 AM