This is an archive of the discontinued LLVM Phabricator instance.

[libcxxabi] Correctly export _Unwind_[GS]et(GR|IP) for EHABI.
ClosedPublic

Authored by danalbert on Oct 13 2014, 11:09 AM.

Details

Summary

These need to have normal linkage instead of being static inline as
many libraries expect to be able to declare these and have the linker
find them rather than needing to include the header.

Also clean up some warnings while I'm here.

Diff Detail

Event Timeline

danalbert updated this revision to Diff 14806.Oct 13 2014, 11:09 AM
danalbert retitled this revision from to [libcxxabi] Correctly export _Unwind_[GS]et(GR|IP) for EHABI..
danalbert updated this object.
danalbert edited the test plan for this revision. (Show Details)
danalbert added a reviewer: jroelofs.
danalbert added a subscriber: Unknown Object (MLST).
jroelofs edited edge metadata.Oct 13 2014, 12:09 PM

This is what I had in mind when we discussed this on irc this morning. Might want to add a link to http://mentorembedded.github.io/cxx-abi/abi-eh.html in the commit message, explaining why you're justified in doing this.

It looks OK to me, but I'll defer to @kledzik on the final go-ahead.

danalbert closed this revision.Oct 13 2014, 2:11 PM
danalbert updated this revision to Diff 14821.

Closed by commit rL219629 (authored by @danalbert).