This is an archive of the discontinued LLVM Phabricator instance.

[x86 asm] allow fwait alias in both At&t and Intel modes (PR21208)
ClosedPublic

Authored by hans on Oct 10 2014, 9:15 PM.

Download Raw Diff

Details

Reviewers

Commits

rGf6aafeee6029: [x86 asm] allow fwait alias in both At&t and Intel modes (PR21208)
rL219725: [x86 asm] allow fwait alias in both At&t and Intel modes (PR21208)

Summary

Please take a look.

Diff Detail

Repository: rL LLVM

Event Timeline

hans updated this revision to Diff 14766.Oct 10 2014, 9:15 PM

hans retitled this revision from to [x86 asm] allow fwait alias in both At&t and Intel modes (PR21208).

hans updated this object.

hans edited the test plan for this revision. (Show Details)

hans added a reviewer: mcrosier.

hans added subscribers: Unknown Object (MLST), • ehsan, hansw.

mcrosier edited reviewers, added: rnk; removed: mcrosier.Oct 13 2014, 6:49 AM

Ping? Or anyone else who'd like to review this?

Oh, I now see Chad added rnk to the reviewers field, but Phab didn't send an email until my ping above.

lgtm

This revision is now accepted and ready to land.Oct 14 2014, 1:01 PM

Closed by commit rL219725 (authored by @hans).

Revision Contents

Path

Size

llvm/

trunk/

lib/

Target/

X86/

X86InstrInfo.td

2 lines

test/

MC/

X86/

x86-32-ms-inline-asm.s

4 lines

Diff 14893

llvm/trunk/lib/Target/X86/X86InstrInfo.td

	Show First 20 Lines • Show All 2,504 Lines • ▼ Show 20 Lines
	def : MnemonicAlias<"fcomip", "fcompi", "att">;			def : MnemonicAlias<"fcomip", "fcompi", "att">;
	def : MnemonicAlias<"fildq", "fildll", "att">;			def : MnemonicAlias<"fildq", "fildll", "att">;
	def : MnemonicAlias<"fistpq", "fistpll", "att">;			def : MnemonicAlias<"fistpq", "fistpll", "att">;
	def : MnemonicAlias<"fisttpq", "fisttpll", "att">;			def : MnemonicAlias<"fisttpq", "fisttpll", "att">;
	def : MnemonicAlias<"fldcww", "fldcw", "att">;			def : MnemonicAlias<"fldcww", "fldcw", "att">;
	def : MnemonicAlias<"fnstcww", "fnstcw", "att">;			def : MnemonicAlias<"fnstcww", "fnstcw", "att">;
	def : MnemonicAlias<"fnstsww", "fnstsw", "att">;			def : MnemonicAlias<"fnstsww", "fnstsw", "att">;
	def : MnemonicAlias<"fucomip", "fucompi", "att">;			def : MnemonicAlias<"fucomip", "fucompi", "att">;
	def : MnemonicAlias<"fwait", "wait", "att">;			def : MnemonicAlias<"fwait", "wait">;


	class CondCodeAlias<string Prefix,string Suffix, string OldCond, string NewCond,			class CondCodeAlias<string Prefix,string Suffix, string OldCond, string NewCond,
	string VariantName>			string VariantName>
	: MnemonicAlias<!strconcat(Prefix, OldCond, Suffix),			: MnemonicAlias<!strconcat(Prefix, OldCond, Suffix),
	!strconcat(Prefix, NewCond, Suffix), VariantName>;			!strconcat(Prefix, NewCond, Suffix), VariantName>;

	/// IntegerCondCodeMnemonicAlias - This multiclass defines a bunch of			/// IntegerCondCodeMnemonicAlias - This multiclass defines a bunch of
	▲ Show 20 Lines • Show All 338 Lines • Show Last 20 Lines

llvm/trunk/test/MC/X86/x86-32-ms-inline-asm.s

	Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Lines
	// CHECK: # encoding: [0x61]			// CHECK: # encoding: [0x61]
	pushad			pushad
	// CHECK: pushal			// CHECK: pushal
	// CHECK: # encoding: [0x60]			// CHECK: # encoding: [0x60]
	popad			popad
	// CHECK: popal			// CHECK: popal
	// CHECK: # encoding: [0x61]			// CHECK: # encoding: [0x61]

				fwait
				// CHECK: wait
				// CHECK: # encoding: [0x9b]

	ret			ret