Page MenuHomePhabricator

[WebAssembly] Handle more types of uses in WebAssemblyAddMissingPrototypes
ClosedPublic

Authored by sbc100 on Jan 18 2019, 2:22 PM.

Details

Summary

Previously we were only handling bitcasts but prototypeless functions
can also appear in comparisons and as function params.Switch to using
replaceAllUsesWith() to replace the prototype-less function uses.

This new approach results in some redundant itcasting but is much
simpler and handles all cases.

Fixes PR40219

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Jan 18 2019, 2:22 PM
sbc100 retitled this revision from [WebAssembly] Handle more types of uses in WebAssemblyAddMissingPrototypes Previously we were only handling bitcasts but prototypeless functions can also appear in comparisons and as function params. Switch to using replaceAllUsesWith() to... to [WebAssembly] Handle more types of uses in WebAssemblyAddMissingPrototypes.Jan 18 2019, 2:23 PM
sbc100 edited the summary of this revision. (Show Details)
sbc100 added reviewers: jgravelle-google, kripken.
sbc100 updated this revision to Diff 182611.Jan 18 2019, 2:31 PM
  • cleanup
jgravelle-google accepted this revision.Jan 28 2019, 4:01 PM

Lgtm
Seems good and simple, ship it

This revision is now accepted and ready to land.Jan 28 2019, 4:01 PM
This revision was automatically updated to reflect the committed changes.