This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Adding CoMD Proxy App
ClosedPublic

Authored by homerdin on Dec 14 2018, 3:00 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

homerdin created this revision.Dec 14 2018, 3:00 PM

The diff seems strange, no files are flagged as new. For instance, the .depend file is seen in Phabricator as "The contents of this file were not changed." I assume the file is empty? Can it be removed from the diff?

MultiSource/Benchmarks/DOE-ProxyApps-C/CoMD/CoMD.reference_output
12–18 ↗(On Diff #178300)

Do these change if test-suite's CMAKE_C_FLAGS, etc. are changed?

47–48 ↗(On Diff #178300)

Should we use a floating-point comparison?

homerdin updated this revision to Diff 178366.Dec 15 2018, 7:54 AM

Thanks for the review!

I fixed the diff

homerdin marked 2 inline comments as done.Dec 15 2018, 8:05 AM
homerdin added inline comments.
MultiSource/Benchmarks/DOE-ProxyApps-C/CoMD/CoMD.reference_output
12–18 ↗(On Diff #178300)

No they will not change, these values are taken from CoMD_info.h. In the original Makefile a script would generate this file automatically. The one being read from in this version will not change.

47–48 ↗(On Diff #178300)

I tested on several platforms and did not need to add a tolerance.

Meinersbur accepted this revision.Dec 17 2018, 8:43 AM

Thanks for updating the patch. It ran successfully on my machine. LGMT.

This revision is now accepted and ready to land.Dec 17 2018, 8:43 AM
This revision was automatically updated to reflect the committed changes.