This is an archive of the discontinued LLVM Phabricator instance.

builtins: avoid endian.h in favour of compiler builtins
ClosedPublic

Authored by compnerd on Sep 30 2014, 8:44 PM.

Reviewers

rengolin
danalbert

Summary

Use the BYTE_ORDER macro which has been available in GCC since 4.6 and is
available in clang as well.

compnerd retitled this revision from to builtins: avoid endian.h in favour of compiler builtins.

compnerd updated this object.

compnerd edited the test plan for this revision. (Show Details)

compnerd added a reviewer: rengolin.

compnerd added a reviewer: danalbert.

compnerd added a subscriber: Unknown Object (MLST).

Ping.

LGTM.

This revision is now accepted and ready to land.Oct 13 2014, 12:06 PM

Sorry it took so long, I completely missed it (even the ping). :(

I believe FreeBSD still uses the old style, but I guess if both compilers support it, it should make no difference, right?

--renato

Has this gone through?

No, sorry, been busy. Ill get this in tomorrow.

Committed as SVN r220626.

Path

Size

lib/

builtins/

7 lines

Context not available.
	/* .. */	/* .. */

	#if defined(__linux__)	#if defined(__linux__)
	#include <endian.h>

	#if __BYTE_ORDER == __BIG_ENDIAN	#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
	#define _YUGA_LITTLE_ENDIAN 0	#define _YUGA_LITTLE_ENDIAN 0
	#define _YUGA_BIG_ENDIAN 1	#define _YUGA_BIG_ENDIAN 1
	#elif __BYTE_ORDER == __LITTLE_ENDIAN	#elif __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
	#define _YUGA_LITTLE_ENDIAN 1	#define _YUGA_LITTLE_ENDIAN 1
	#define _YUGA_BIG_ENDIAN 0	#define _YUGA_BIG_ENDIAN 0
	#endif /* __BYTE_ORDER */	#endif /* __BYTE_ORDER__ */

	#endif /* GNU/Linux */	#endif /* GNU/Linux */

Context not available.