This is an archive of the discontinued LLVM Phabricator instance.

Fix a mistake in r217762
ClosedPublic

Authored by ehsan on Sep 25 2014, 10:15 AM.

Details

Summary

The extra macro definition needs to go into COMPILER_RT_GTEST_CFLAGS
in order to be used for gtests on MSVC2012.

Diff Detail

Event Timeline

ehsan updated this revision to Diff 14078.Sep 25 2014, 10:15 AM
ehsan retitled this revision from to Fix a mistake in r217762.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: timurrrr.
ehsan added a subscriber: Unknown Object (MLST).
rnk accepted this revision.Sep 25 2014, 12:51 PM
rnk added a reviewer: rnk.
rnk added a subscriber: rnk.

lgtm

This revision is now accepted and ready to land.Sep 25 2014, 12:51 PM
timurrrr edited edge metadata.Sep 25 2014, 1:24 PM

LGTM, I've made similar mistakes like 10 times – looks like these variables are not convenient to use...
The outtake is: try the patch before committing :)

timurrrr accepted this revision.Sep 25 2014, 1:24 PM
timurrrr edited edge metadata.
In D5493#9, @timurrrr wrote:

LGTM, I've made similar mistakes like 10 times – looks like these variables are not convenient to use...
The outtake is: try the patch before committing :)

Haha! FWIW, I had tried this patch, the issue is that I develop on a VM which doesn't have my real SSH keys so usually I push out my changes to my main machine and submit them from review there, but sometimes for small changes like this, I type in the patch manually for submission, and... I screw things up. :)

ehsan closed this revision.Sep 25 2014, 1:52 PM
ehsan updated this revision to Diff 14086.

Closed by commit rL218464 (authored by @ehsan).