Enable UBSan on Windows

[timurrrr]

cmake/config-ix.cmake

205

have you tried UBSan on Win64?

lib/ubsan/ubsan_value.h

17

You should probably update the comment.

19

nit: you've crossed the "80 chars per string" limit.

You might want to try clang-format to fix this and other coding style related issues.

[akhaldi]

cmake/config-ix.cmake

205

No, which is why I kept the 32bit check for now.

lib/ubsan/ubsan_value.h

17

Noted.

19

I'm not familiar with the tool, but I'll look into it.

[samsonov]

Does UBSan actually builds and works on Windows? What about MSVC? How did you test it?

[emaste]

lib/ubsan/ubsan_value.h

17

It's clear from the following #if conditions which platforms are supported, no point in repeating the list in a comment immediately prior. How about:

// Only certain platforms are supported. Others should be easy to add, and may work as-is.

[compnerd]

cmake/config-ix.cmake

205

What about WoA (32-bit)?

cmake/config-ix.cmake

 if (COMPILER_RT_HAS_SANITIZER_COMMON AND TSAN_SUPPORTED_ARCH AND
     OS_NAME MATCHES "Linux")
   set(COMPILER_RT_HAS_TSAN TRUE)
 else()
   set(COMPILER_RT_HAS_TSAN FALSE)
 endif()
 
 if (COMPILER_RT_HAS_SANITIZER_COMMON AND UBSAN_SUPPORTED_ARCH AND
-    OS_NAME MATCHES "Darwin|Linux|FreeBSD")
+    OS_NAME MATCHES "Darwin|Linux|FreeBSD" OR
+    (OS_NAME MATCHES "Windows" AND CMAKE_SIZEOF_VOID_P EQUAL 4))
   set(COMPILER_RT_HAS_UBSAN TRUE)
 else()
   set(COMPILER_RT_HAS_UBSAN FALSE)
 endif()
 

lib/ubsan/ubsan_value.h

 //===-- ubsan_value.h -------------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // Representation of data which is passed from the compiler-generated calls into
 // the ubsan runtime.
 //
 //===----------------------------------------------------------------------===//
 #ifndef UBSAN_VALUE_H
 #define UBSAN_VALUE_H
 
 // For now, only support Linux, FreeBSD and Darwin. Other platforms should
 // be easy to add, and probably work as-is.
-#if !defined(__linux__) && !defined(__FreeBSD__) && !defined(__APPLE__)
+#if !defined(__linux__) && !defined(__FreeBSD__) && !defined(__APPLE__) && !defined(_WIN32)
 #error "UBSan not supported for this platform!"
 #endif
 
 #include "sanitizer_common/sanitizer_atomic.h"
 #include "sanitizer_common/sanitizer_common.h"
 
 // FIXME: Move this out to a config header.
 #if __SIZEOF_INT128__