This is an archive of the discontinued LLVM Phabricator instance.

Make test/Driver hermetic
ClosedPublic

Authored by jfb on Sep 14 2014, 4:51 PM.

Details

Summary

The includes shouldn't be there, use the compiler's built-in types/macros instead.

This is a follow-up to r217694, as discussed in:

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140908/114669.html

Diff Detail

Repository
rL LLVM

Event Timeline

jfb updated this revision to Diff 13688.Sep 14 2014, 4:51 PM
jfb retitled this revision from to Make test/Driver hermetic.
jfb updated this object.
jfb edited the test plan for this revision. (Show Details)
jfb added reviewers: nlewycky, thakis, echristo, chandlerc.
jfb added a subscriber: Unknown Object (MLST).
jfb closed this revision.Sep 14 2014, 4:52 PM
jfb updated this revision to Diff 13689.

Closed by commit rL217743 (authored by @jfb).

chandlerc edited edge metadata.Sep 14 2014, 4:55 PM

Heh, i mean, LGTM... Not sure why you sent for review and then immediately committed?

jfb added a comment.Sep 14 2014, 5:51 PM

As an FYI, since we agreed on the previous thread.