This is an archive of the discontinued LLVM Phabricator instance.

clang-cl: Warn when a /TC or /TP argument is unused
ClosedPublic

Authored by ehsan on Sep 12 2014, 12:13 PM.

Diff Detail

Event Timeline

ehsan updated this revision to Diff 13655.Sep 12 2014, 12:13 PM
ehsan retitled this revision from to clang-cl: Warn when a /TC or /TP argument is unused.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added a reviewer: hansw.
ehsan added a subscriber: Unknown Object (MLST).
hans added a subscriber: hans.Sep 12 2014, 12:44 PM
hans added inline comments.
test/Driver/cl-inputs.c
49

Can't you just att this to the TPlib checks above? (And similarly for /TC below.)

ehsan added inline comments.Sep 12 2014, 12:52 PM
test/Driver/cl-inputs.c
49

No, note the %s in the tests above. In those tests, /TC and /TP are used on cl-inputs.c.

hans added inline comments.Sep 12 2014, 12:58 PM
test/Driver/cl-inputs.c
49

Ah, I didn't notice the %s before.

It still seems that these two tests are very similar. How about dropping the %s above and merging them?

ehsan added inline comments.Sep 12 2014, 2:06 PM
test/Driver/cl-inputs.c
49

The first test does ensure that we generate one command for the compilation of cl-inputs.c and the second test doesn't. I don't think they are quite identical. But if you think that distinction isn't worth having two separate tests for, I'd be happy to merge them.

hans added inline comments.Sep 12 2014, 2:09 PM
test/Driver/cl-inputs.c
49

Yeah, I don't think that distinction is important.

The way I see it, the important part of the first test is that cl-test.lib doesn't get "compiled".

ehsan updated this revision to Diff 13661.Sep 12 2014, 2:49 PM

Addressed the comments!

hans accepted this revision.Sep 12 2014, 2:53 PM
hans added a reviewer: hans.

lgtm

This revision is now accepted and ready to land.Sep 12 2014, 2:53 PM
ehsan closed this revision.Sep 12 2014, 2:54 PM
ehsan updated this revision to Diff 13662.

Closed by commit rL217710 (authored by @ehsan).