Make anonymous namespace as small as possible.

[ruiu]

Summary

LLVM coding style says that "static" is preferred for file-scope
functions.

[kledzik]

Interesting. That is the way I used to write C++, but I thought the LLVM convention preferred anonymous namespaces. After reading the current LLVM convention doc, I see that static is better in this case. I'll retrain my fingers :-)

LGTM

[ruiu]

Closed by commit rL217692 (authored by @ruiu).

lld/trunk/lib/Driver/DarwinLdDriver.cpp

 };
 
 // Create OptTable class for parsing actual command line arguments
 class DarwinLdOptTable : public llvm::opt::OptTable {
 public:
   DarwinLdOptTable() : OptTable(infoTable, llvm::array_lengthof(infoTable)){}
 };
 
+} // anonymous namespace
+
 // Test may be running on Windows. Canonicalize the path
 // separator to '/' to get consistent outputs for tests.
-std::string canonicalizePath(StringRef path) {
+static std::string canonicalizePath(StringRef path) {
   char sep = llvm::sys::path::get_separator().front();
   if (sep != '/') {
     std::string fixedPath = path;
     std::replace(fixedPath.begin(), fixedPath.end(), sep, '/');
     return fixedPath;
   } else {
     return path;
   }
 }
 
-void addFile(StringRef path, std::unique_ptr<InputGraph> &inputGraph,
+static void addFile(StringRef path, std::unique_ptr<InputGraph> &inputGraph,
                     bool forceLoad) {
    inputGraph->addInputElement(std::unique_ptr<InputElement>(
                                           new MachOFileNode(path, forceLoad)));
 }
 
 // Export lists are one symbol per line.  Blank lines are ignored.
 // Trailing comments start with #.
-std::error_code parseExportsList(StringRef exportFilePath,
+static std::error_code parseExportsList(StringRef exportFilePath,
                                         MachOLinkingContext &ctx,
                                         raw_ostream &diagnostics) {
   // Map in export list file.
   ErrorOr<std::unique_ptr<MemoryBuffer>> mb =
                                    MemoryBuffer::getFileOrSTDIN(exportFilePath);
   if (std::error_code ec = mb.getError())
     return ec;
   StringRef buffer = mb->get()->getBuffer();
   while (!buffer.empty()) {
     // Split off each line in the file.

 //   -filelist <path>
 // In this variant, the path is to a text file which contains one file path
 // per line.  There are no comments or trimming of whitespace.
 //
 //   -fileList <path>,<dir>
 // In this variant, the path is to a text file which contains a partial path
 // per line. The <dir> prefix is prepended to each partial path.
 //
-std::error_code parseFileList(StringRef fileListPath,
+static std::error_code parseFileList(StringRef fileListPath,
                                      std::unique_ptr<InputGraph> &inputGraph,
                                      MachOLinkingContext &ctx, bool forceLoad,
                                      raw_ostream &diagnostics) {
   // If there is a comma, split off <dir>.
   std::pair<StringRef, StringRef> opt = fileListPath.split(',');
   StringRef filePath = opt.first;
   StringRef dirName = opt.second;
   // Map in file list file.
   ErrorOr<std::unique_ptr<MemoryBuffer>> mb =
                                         MemoryBuffer::getFileOrSTDIN(filePath);
   if (std::error_code ec = mb.getError())
while (!buffer.empty()) {
     }
     addFile(path, inputGraph, forceLoad);
     buffer = lineAndRest.second;
   }
   return std::error_code();
 }
 
 /// Parse number assuming it is base 16, but allow 0x prefix.
-bool parseNumberBase16(StringRef numStr, uint64_t &baseAddress) {
+static bool parseNumberBase16(StringRef numStr, uint64_t &baseAddress) {
   if (numStr.startswith_lower("0x"))
     numStr = numStr.drop_front(2);
   return numStr.getAsInteger(16, baseAddress);
 }
 
-} // namespace anonymous
-
 namespace lld {
 
 bool DarwinLdDriver::linkMachO(int argc, const char *argv[],
                                raw_ostream &diagnostics) {
   MachOLinkingContext ctx;
   if (!parse(argc, argv, ctx, diagnostics))
     return false;
   if (ctx.doNothing())