This is an archive of the discontinued LLVM Phabricator instance.

Add support for le64.
ClosedPublic

Authored by jfb on Sep 11 2014, 3:08 PM.

Details

Summary

le64 is a generic little-endian 64-bit processor, mimicking le32.

Also see the associated LLVM change, D5319.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb updated this revision to Diff 13606.Sep 11 2014, 3:08 PM
jfb retitled this revision from to Add support for le64..
jfb updated this object.
jfb edited the test plan for this revision. (Show Details)
jfb added a reviewer: dschuff.
jfb added a subscriber: Unknown Object (MLST).
jfb updated this object.Sep 11 2014, 3:10 PM
jfb edited subscribers, added: Unknown Object (MLST); removed: Unknown Object (MLST).
jfb updated this revision to Diff 13640.Sep 12 2014, 10:05 AM
  • Fix copy/paste for test, the triple should be le64-unknown-unknown
dschuff accepted this revision.Sep 12 2014, 10:17 AM
dschuff edited edge metadata.
dschuff added inline comments.
lib/Basic/Targets.cpp
6009 ↗(On Diff #13640)

you can remove the support for pnaclcall callingconv, which we dont use anymore. Once we merge to tip, I'm going to remove it upstream.

This revision is now accepted and ready to land.Sep 12 2014, 10:17 AM
jfb updated this revision to Diff 13642.Sep 12 2014, 10:24 AM
jfb edited edge metadata.
  • No need to use PNaCl's calling convention since PNaCl now uses a separate approach for calling conventions.

So you mean we can delete CC_PnaclCall and attr_pnaclcall from clang?

In D5318#14, @rafael wrote:

So you mean we can delete CC_PnaclCall and attr_pnaclcall from clang?

Yes. We are currently in the process of merging our changes up to tip, at which point I plan on doing it myself. But if you are in a hurry I'll be happy to review it before then :)

By the way, it should be safe to just remove it completely, right? There aren't any enums or anything that need to remain stable?

jfb closed this revision.Sep 12 2014, 11:02 AM
jfb updated this revision to Diff 13646.

Closed by commit rL217694 (authored by @jfb).