Page MenuHomePhabricator

[WebAssembly] Be a little more conservative in WebAssemblyFixFunctionBitcasts
ClosedPublic

Authored by sbc100 on Aug 29 2018, 3:15 PM.

Details

Summary

We don't have enough information to know if struct types being
bitcast will cause validation failures or not, so be conservative
and allow such cases to persist (not now).

Fixes: https://bugs.llvm.org/show_bug.cgi?id=38711

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Aug 29 2018, 3:15 PM
sbc100 added a subscriber: alexcrichton.
jgravelle-google accepted this revision.Aug 29 2018, 4:15 PM

The change feels a bit screwy to me, but I can't think of any alternative ways to factor this that aren't worse.

test/CodeGen/WebAssembly/function-bitcasts.ll
23 ↗(On Diff #163204)

One too many spaces after call?

This revision is now accepted and ready to land.Aug 29 2018, 4:15 PM

In some local tests it looks like this fixes the issue we were seeing, thanks so much!

This revision was automatically updated to reflect the committed changes.