Page MenuHomePhabricator

Fix IR Printing test
AcceptedPublic

Authored by tyb0807 on Jul 14 2018, 12:25 AM.

Details

Reviewers
dexonsmith
davide
Summary

Hello,

I just saw the comment from Davide and Duncan. I hope this patch fixes the issue.

Thanks for your time

Diff Detail

Event Timeline

tyb0807 created this revision.Jul 14 2018, 12:25 AM

Shouldn't this have -print-module in the command-line, since that's what this is supposed to be testing? I must have missed that in the original review.

-S already inserts a -print-module to the pipeline. But I can explicitly add that option to the command line if you want

tyb0807 updated this revision to Diff 156450.Jul 20 2018, 2:28 AM

@dexonsmith Is it better now?

davide accepted this revision.Jul 20 2018, 8:11 AM

lgtm.

This revision is now accepted and ready to land.Jul 20 2018, 8:11 AM
dexonsmith accepted this revision.Jul 20 2018, 8:33 AM

LGTM too.

Can anyone commit this on my behalf please?

Thank you for your time