Page MenuHomePhabricator

tyb0807 (Son Tuan Vu)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 30 2018, 8:00 AM (130 w, 1 d)

Recent Activity

Nov 14 2018

tyb0807 reopened D45045: [DebugInfo] Generate debug information for labels..

Hello all,

Nov 14 2018, 11:49 PM

Jul 23 2018

tyb0807 added a comment to D49340: Fix IR Printing test.

Can anyone commit this on my behalf please?

Jul 23 2018, 12:49 AM

Jul 20 2018

tyb0807 updated the diff for D49340: Fix IR Printing test.

@dexonsmith Is it better now?

Jul 20 2018, 2:28 AM

Jul 18 2018

tyb0807 added a comment to D49297: expose debugify as an LLVM option in clang.

Thank you for your comment. I agree with what you say, however, I think you may understand that we should have had this discussion before this patch in https://bugs.llvm.org/show_bug.cgi?id=37792 😭

Jul 18 2018, 12:10 AM

Jul 17 2018

tyb0807 added a comment to D49297: expose debugify as an LLVM option in clang.

Thanks for your comment Greg. Please feel free to tell me if you need anything else I'll try to update the patch.

Jul 17 2018, 2:31 PM

Jul 16 2018

tyb0807 added a comment to D49340: Fix IR Printing test.

-S already inserts a -print-module to the pipeline. But I can explicitly add that option to the command line if you want

Jul 16 2018, 9:56 AM

Jul 14 2018

tyb0807 created D49340: Fix IR Printing test.
Jul 14 2018, 12:26 AM

Jul 13 2018

tyb0807 created D49297: expose debugify as an LLVM option in clang.
Jul 13 2018, 7:59 AM
tyb0807 created D49291: [LegacyPassManager] Fix dumpPassArguments() for clang.
Jul 13 2018, 6:29 AM

Jul 11 2018

tyb0807 added a comment to D48723: Fix IRPrinting bug.

Friendly ping!

Jul 11 2018, 11:24 AM

Jul 6 2018

tyb0807 added a comment to D48723: Fix IRPrinting bug.

Thank you for reviewing this. Unfortunately I do not have the commit access, can you do it on my behalf please?
Thank you again

Jul 6 2018, 1:47 AM

Jul 5 2018

tyb0807 added a comment to D48723: Fix IRPrinting bug.

Is it better now?

Jul 5 2018, 2:11 AM

Jun 29 2018

tyb0807 added a comment to D48723: Fix IRPrinting bug.

I think it would be oddly divergent if these are analyses in one pass manager and not the other, which is why I'm pushing to understand what we'll do for both.

Jun 29 2018, 11:22 AM
tyb0807 updated the diff for D48723: Fix IRPrinting bug.

Addressed review comment.

Jun 29 2018, 11:03 AM
tyb0807 updated the diff for D48723: Fix IRPrinting bug.

No don't get me wrong, this patch is supposed to fix the issue in the LegacyPassManager, and I do not intend to change anything about the new pass manager in this patch.

Jun 29 2018, 7:37 AM

Jun 28 2018

tyb0807 added a comment to D48723: Fix IRPrinting bug.

Thanks for taking a look at this. However, IIRC, the new pass manager does not have print-before/after(-all) mode yet. That is the next thing that I want to do (if you agree, of course)

Jun 28 2018, 3:18 PM
tyb0807 updated the summary of D48723: Fix IRPrinting bug.
Jun 28 2018, 7:50 AM
tyb0807 updated the summary of D48723: Fix IRPrinting bug.
Jun 28 2018, 7:49 AM
tyb0807 created D48723: Fix IRPrinting bug.
Jun 28 2018, 7:46 AM
tyb0807 abandoned D46815: [DbgInfo] Fix StripDebugInfo.
Jun 28 2018, 6:46 AM

Jun 4 2018

tyb0807 added a comment to D46815: [DbgInfo] Fix StripDebugInfo.

I get it now. Thank you for your time. So anything else that needs to be fixed? Otherwise I'll tackle the verify-each mode

Jun 4 2018, 1:15 PM
tyb0807 added a comment to D46815: [DbgInfo] Fix StripDebugInfo.

Hmmm, sorry but I still don't understand how do we remove declare @llvm.dbg.* from the IR though? Or you think that this is not necessary?

Jun 4 2018, 10:29 AM
tyb0807 added a comment to D46815: [DbgInfo] Fix StripDebugInfo.

Yes, you'll have to do opt -strip-debug -strip-dead-prototypes. What is done in strip-dead-prototypes is exactly what we do here though... I'm not sure what would cause the ThinLTO test fail...

Jun 4 2018, 6:26 AM
tyb0807 added a comment to D45556: [DebugInfo] Generate DWARF debug information for labels..

Thank you for the patch.

It seems to me that with requireLabelBeforeInsn, the label will later be emitted as a temporary symbol with a unique but unspecified name (in DebugHandleBase::beginInstruction()). Is it correct?

Yes, I generate a temporary label before the label intrinsic. In this way, I could get the address of the label afterward.

Yes, I mean that the label will later be named differently in the asm file than in the source? I don't know if this is something we should care about though, I'm just speaking from an user point of view

Jun 4 2018, 6:21 AM

May 29 2018

tyb0807 added a comment to D45556: [DebugInfo] Generate DWARF debug information for labels..

Thank you for the patch.

May 29 2018, 1:51 AM

May 22 2018

tyb0807 added a comment to D46815: [DbgInfo] Fix StripDebugInfo.

Yes please commit this on my behalf.

May 22 2018, 12:39 AM

May 18 2018

tyb0807 updated the diff for D46815: [DbgInfo] Fix StripDebugInfo.

Sure, the patch is updated accordingly.

May 18 2018, 9:19 AM
tyb0807 updated the diff for D46815: [DbgInfo] Fix StripDebugInfo.

Context added

May 18 2018, 2:37 AM

May 16 2018

tyb0807 updated the diff for D46815: [DbgInfo] Fix StripDebugInfo.

Addressed review comments. Thank you for the help

May 16 2018, 2:23 AM

May 15 2018

tyb0807 updated the diff for D46815: [DbgInfo] Fix StripDebugInfo.

The test is now simplified. Please tell me if you really want to remove -strip-debugify option and use -strip-debug instead.

May 15 2018, 2:25 PM
tyb0807 updated the diff for D46815: [DbgInfo] Fix StripDebugInfo.

Address review comments. Other comments inlined

May 15 2018, 5:19 AM

May 14 2018

tyb0807 added a comment to D46815: [DbgInfo] Fix StripDebugInfo.

UPD: There are 3 regression tests that declare functions starting with llvm.dbg. (e.g. declare void @llvm.dbg.func.start(metadata) nounwind readnone) and are failing:

  • Linker/2009-09-03-mdnode.ll
  • Transforms/SimplifyCFG/2003-08-17-FoldSwitch-dbg.ll
  • Transforms/SimplifyCFG/dbginfo.ll
May 14 2018, 12:39 AM

May 13 2018

tyb0807 created D46815: [DbgInfo] Fix StripDebugInfo.
May 13 2018, 3:59 PM
tyb0807 added a comment to D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass.

Thank you Vedant. I do not have commit access, please commit this for me.

May 13 2018, 1:41 AM

May 12 2018

tyb0807 updated the diff for D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass.

Sorry it was a local change, forgot to remove it before diffing. Please tell me if there's any way to handle local change while still being able to create patch properly.

May 12 2018, 12:55 AM

May 11 2018

tyb0807 updated the diff for D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass.

Addressed review comments.

May 11 2018, 3:49 PM
tyb0807 updated the diff for D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass.

Address review comments. Now we print out the module when check-debugify reports an error. I guess another important information should be the optimization pass that makes check-debugify fail, but I'm not sure how to get that information though.

May 11 2018, 3:55 AM

May 10 2018

tyb0807 added a comment to D46599: [DbgInfo] Attempt to fix bug 37149.

I've posted a reduced test case in https://bugs.llvm.org/show_bug.cgi?id=37149.

May 10 2018, 2:15 PM

May 9 2018

tyb0807 added a comment to D46599: [DbgInfo] Attempt to fix bug 37149.

@aprantl Yes that is exactly what I am doing.
@rob.lougher As you pointed out, I was hoping that this change would not change the splitting in RegAlloc, but apparently it is not the case. The test added in D35953 does not pass anymore. Instead of

[0x000000000000001f, 0x000000000000003c): DW_OP_reg3 RBX

we now have

[0x000000000000000e,  0x0000000000000013): DW_OP_reg2 RCX
[0x0000000000000013,  0x000000000000003c): DW_OP_reg3 RBX

I do not understand why though... RegAlloc should not be broken this way :(. I'll update a reduced test case reflecting the PR37149's issue so you can tell me how it should be fixed.

May 9 2018, 3:43 PM
tyb0807 added a comment to D46599: [DbgInfo] Attempt to fix bug 37149.

Urgh, sorry but ... what new check? The only check is just transforming SmallSet::count() into SmallDenseMap::find() + comparing with SmallDenseMap::end(), so just to check whether the interval start was trimmed to the lexical scope (which is already commented in L1210).

May 9 2018, 8:10 AM
tyb0807 updated the diff for D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass.

Hello Vedant,

May 9 2018, 5:24 AM

May 8 2018

tyb0807 created D46599: [DbgInfo] Attempt to fix bug 37149.
May 8 2018, 1:43 PM

May 7 2018

tyb0807 created D46525: [Debugify] Introduce debugify-each and DebugifyFunctionPass.
May 7 2018, 6:59 AM

Apr 23 2018

tyb0807 added a comment to D45772: [Minor patch] Fix IR Module Printing.

Hmmm, the problem is in AssemblyWriter::printFunction(), we already print a newline character at the start of the function, so in fact this issue only raises when we print ModulePasses. Removing the newline character printing in AssemblyWriter::printFunction() will lead to this:

@x = common dso_local global i32 0, align 4
@y = common dso_local global i32 0, align 4
@z = common dso_local global i32 0, align 4
; Function Attrs: noinline nounwind uwtable

instead of this:

@x = common dso_local global i32 0, align 4
@y = common dso_local global i32 0, align 4
@z = common dso_local global i32 0, align 4
Apr 23 2018, 8:03 AM
tyb0807 added a reviewer for D45772: [Minor patch] Fix IR Module Printing: chandlerc.
Apr 23 2018, 4:25 AM
tyb0807 added a reviewer for D45772: [Minor patch] Fix IR Module Printing: dexonsmith.

svn blame leads me to this

Apr 23 2018, 4:22 AM

Apr 18 2018

tyb0807 added a comment to D45772: [Minor patch] Fix IR Module Printing.

So for now, with -print-after-all or -print-before-all options in opt, we have the banner and the first line of the IR Module on a same line, e.g:

*** IR Dump After Force set function attributes *** ; ModuleID = '<stdin>'
source_filename = "main.c"
...
Apr 18 2018, 2:43 PM
tyb0807 created D45772: [Minor patch] Fix IR Module Printing.
Apr 18 2018, 8:08 AM

Mar 30 2018

tyb0807 added a watcher for debug-info: tyb0807.
Mar 30 2018, 8:02 AM