This is an archive of the discontinued LLVM Phabricator instance.

Add missing breaks to AArch64InstrInfo::is{G,F}PRCopy
ClosedPublic

Authored by rengolin on Aug 1 2014, 8:36 AM.

Details

Reviewers
t.p.northover
Summary

Silly omission in one case, future-proof in other two. Caught by Coverity.

Tim, just making sure the "silly omission" was actually not intended.

Diff Detail

Event Timeline

rengolin updated this revision to Diff 12108.Aug 1 2014, 8:36 AM
rengolin retitled this revision from to Add missing breaks to AArch64InstrInfo::is{G,F}PRCopy.
rengolin updated this object.
rengolin edited the test plan for this revision. (Show Details)
rengolin added a reviewer: t.p.northover.
rengolin set the repository for this revision to rL LLVM.
rengolin added a project: deleted.
rengolin added subscribers: jmolloy, Unknown Object (MLST).
t.p.northover accepted this revision.Aug 1 2014, 10:33 AM
t.p.northover edited edge metadata.

Hi Renato,

I think this one's reasonable. The lack of tests it a bit disturbing, but fine in my opinion (constructing one would be very difficult, with a very fragile result). The change is obviously correct.

Cheers.

Tim.

This revision is now accepted and ready to land.Aug 1 2014, 10:33 AM
rengolin closed this revision.Aug 1 2014, 10:36 AM

Thanks, r214528.