Silly omission in one case, future-proof in other two. Caught by Coverity.
Tim, just making sure the "silly omission" was actually not intended.
Paths
| Differential D4757
Add missing breaks to AArch64InstrInfo::is{G,F}PRCopy ClosedPublic Authored by rengolin on Aug 1 2014, 8:36 AM.
Details
Summary Silly omission in one case, future-proof in other two. Caught by Coverity. Tim, just making sure the "silly omission" was actually not intended.
Diff Detail Event Timelinerengolin updated this object. t.p.northover edited edge metadata. Comment ActionsHi Renato, I think this one's reasonable. The lack of tests it a bit disturbing, but fine in my opinion (constructing one would be very difficult, with a very fragile result). The change is obviously correct. Cheers. Tim. This revision is now accepted and ready to land.Aug 1 2014, 10:33 AM
Revision Contents
Diff 12108 lib/Target/AArch64/AArch64InstrInfo.cpp
|