Page MenuHomePhabricator

Makefile.rules: Don't rely on the shell to perform wildcard expansion
ClosedPublic

Authored by majnemer on Jul 30 2014, 3:31 PM.

Details

Summary

It is possible to use make on Windows without using a Unix-like shell.
However, our makefile assumes that the shell is capable of glob
behavior. Instead of hoping the shell will expand the wildcard, do it
upfront in the makefile itself.

Diff Detail

Event Timeline

majnemer updated this revision to Diff 12048.Jul 30 2014, 3:31 PM
majnemer retitled this revision from to Makefile.rules: Don't rely on the shell to perform wildcard expansion.
majnemer updated this object.
majnemer added reviewers: zturner, tfiala.
majnemer added a subscriber: Unknown Object (MLST).
zturner edited edge metadata.Jul 30 2014, 4:16 PM

I fixed up a few more instances of shell-based globbing. Some of these are
MacOSX only, and this only really matters on Windows, but I figured it's
best to just be consistent and adopt a policy of "always use $(wildcard)
for globbing.

emaste accepted this revision.Jul 30 2014, 4:49 PM
emaste added a reviewer: emaste.
This revision is now accepted and ready to land.Jul 30 2014, 4:49 PM
zturner closed this revision.Aug 2 2014, 12:37 AM

This was submitted in r214441