Page MenuHomePhabricator

Fix supported Architectures for PlatformWindows

Authored by zturner on Jul 24 2014, 10:20 AM.



i386, i486, i486sx, and i686 are all indistinguishable as far as PE/COFF files are concerned. This patch adds support for all of these architectures to PlatformWindows.

Diff Detail


Event Timeline

zturner updated this revision to Diff 11844.Jul 24 2014, 10:20 AM
zturner retitled this revision from to Fix supported Architectures for PlatformWindows.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: tfiala.
zturner added a subscriber: Unknown Object (MLST).
majnemer added inline comments.
47 ↗(On Diff #11844)

This does not appear to be a valid triple, using it in clang gives the following:
error: unknown target triple 'i486sx-pc-windows-msvc', please use -triple or -arch

zturner updated this revision to Diff 11846.Jul 24 2014, 10:51 AM

Remove i486 and i486sx, only support i386 and i686

zturner closed this revision.Jul 28 2014, 9:53 AM
zturner updated this revision to Diff 11947.

Closed by commit rL214092 (authored by @zturner).