Yet another step toward ARM64 support. With this commit, lldb-gdbserver started on ARM64 target can be accessed by lldb running on desktop PC and it can process simple commands (like 'continue'). Still ARM64 support lacks NativeRegisterContextLinux_arm64.* code which waits to be implemented.
Based on similar files for Linux x86_64 and Darwin ARM64. Due to common code extraction from Darwin related files, lldb should be tested for any unexpected regression on Darwin ARM64 machines too.
Details
Details
- Reviewers
tfiala
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Same with this - did this go in while I was on vacation?
Looking to close out some reviews that are still listed as open.
Comment Actions
Ok - marking as accepted and closing out (with understanding this functionality already went in via another patch).
Comment Actions
I just tested this patch against lldb/llvm/clang svn r216668.
The only changes needed were to convert Host:: to HostInfo:: in POSIXThread.cpp and NativeThreadLinux.cpp.
The tests came back clean on x86_64 Ubuntu and MacOSX 10.9.4.
Waiting on Apple review (just sent out email) of header file changes in RegisterContextDarwin_arm64.cpp and friends.
Comment Actions
Submitted here, with a minor tweak:
svn commit Sending source/Plugins/Process/Linux/NativeThreadLinux.cpp Sending source/Plugins/Process/POSIX/POSIXThread.cpp Sending source/Plugins/Process/Utility/CMakeLists.txt Sending source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp Adding source/Plugins/Process/Utility/RegisterContextLinux_arm64.cpp Adding source/Plugins/Process/Utility/RegisterContextLinux_arm64.h Adding source/Plugins/Process/Utility/RegisterInfos_arm64.h Sending source/Utility/ARM64_GCC_Registers.h Transmitting file data ........ Committed revision 216737.