This is an archive of the discontinued LLVM Phabricator instance.

MC: Let non-temporary COFF aliases be in symtab
ClosedPublic

Authored by majnemer on Jul 4 2014, 5:53 PM.

Details

Summary

MC was aping a binutils bug, there is no reason to desire the existing
behavior.

This fixes PR20152.

Diff Detail

Event Timeline

majnemer updated this revision to Diff 11097.Jul 4 2014, 5:53 PM
majnemer retitled this revision from to MC: Let non-temporary COFF aliases be in symtab.
majnemer updated this object.
majnemer added reviewers: rafael, rnk.
majnemer added a subscriber: Unknown Object (MLST).
rnk accepted this revision.Jul 7 2014, 5:45 PM
rnk edited edge metadata.

lgtm

Looks like upstream binutils agrees, at least for PE/COFF, which is the only COFF we care about:
https://sourceware.org/ml/binutils/2014-07/msg00057.html

lib/MC/WinCOFFObjectWriter.cpp
554–565

Is this comment still accurate?

test/MC/COFF/lset0.s
9–11

If you want to be really airtight, you need to CHECK-NOT before and after each CHECK or do a separate FileCheck run.

This revision is now accepted and ready to land.Jul 7 2014, 5:45 PM

My binutils patch hasn't been accepted yet, I think I will wait to land this patch when the other lands.

majnemer updated this revision to Diff 11142.Jul 7 2014, 11:09 PM
majnemer edited edge metadata.
  • Address review comments.
rafael accepted this revision.Jul 8 2014, 8:57 AM
rafael edited edge metadata.

This lgtm once the binutils change lands.

majnemer closed this revision.Jul 12 2014, 9:39 PM
majnemer updated this revision to Diff 11343.

Closed by commit rL212899 (authored by @majnemer).