This is an archive of the discontinued LLVM Phabricator instance.

[GSoC] Dominators project proposal
ClosedPublic

Authored by kuhar on Feb 18 2018, 9:12 PM.

Details

Summary

The GSoC project proposal I came up with -- to implement a single updater class for performing incremental dominator tree updates. The main goal is to make the use of the updater easier and to simplify existing APIs. The secondary goal is to perform cheaper PDT updates when having and already updated DT available.

I want to make sure that the proposal and the way it's written is reasonable before going forward with it.

Diff Detail

Repository
rL LLVM

Event Timeline

kuhar created this revision.Feb 18 2018, 9:12 PM
grosser accepted this revision.Feb 18 2018, 10:04 PM

Very nice! I like the proposal!

This revision is now accepted and ready to land.Feb 18 2018, 10:04 PM
davide accepted this revision.Feb 19 2018, 8:51 AM

lg, thanks for taking care of this.

+1 from me. I'd love to see a single interface for all Dominator-related analysis or updates. This idea reminds me (a bit) of a comment @dberlin made in D43173 about an interface similar to getBestSimplifyQuery to reduce the number of functions that need explicit pointers to a DT, DDT, PDT or other analysis object. I don't quite understand how this would work but I wanted to bring it up in case the work could be done in a way to anticipate such an interface to reduce re-work.

This revision was automatically updated to reflect the committed changes.