This is an archive of the discontinued LLVM Phabricator instance.

Add some natvis visualizers for llvm::Value, llvm::Type, and llvm::Instruction
AbandonedPublic

Authored by zturner on Jun 26 2014, 11:41 AM.

Details

Reviewers
aaron.ballman
Summary

Figures out the derived type of an llvm::Type, and adds an entry to the watch window that automatically casts to the derived type.

Also adds a visualizer to display the opcode of an llvm::Instruction

I'm not very good at writing these, so I'm not sure if this is the best possible way to express this.

Diff Detail

Event Timeline

zturner updated this revision to Diff 10899.Jun 26 2014, 11:41 AM
zturner retitled this revision from to Add some natvis visualizers for llvm::Value and llvm::Type.
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a reviewer: aaron.ballman.
zturner added a subscriber: Unknown Object (MLST).
zturner updated this revision to Diff 10902.Jun 26 2014, 2:01 PM
zturner retitled this revision from Add some natvis visualizers for llvm::Value and llvm::Type to Add some natvis visualizers for llvm::Value, llvm::Type, and llvm::Instruction.
zturner updated this object.

Added some more for llvm::Instruction to display the Opcode.

aaron.ballman accepted this revision.Oct 13 2015, 5:54 AM
aaron.ballman edited edge metadata.

Sorry for not saying this sooner, but LGTM on its face. I don't know LLVM datatypes particularly well, so they may have changed in the intervening year and a half. ;-) If you feel like testing this against ToT, I think the approach is correct and you can land with any required modifications.

~Aaron

This revision is now accepted and ready to land.Oct 13 2015, 5:54 AM
zturner abandoned this revision.Oct 15 2015, 1:49 PM

Not sure if this is still relevant and I haven't done much on LLVM in a while, so abandoning it for the time being.