This is an archive of the discontinued LLVM Phabricator instance.

Don't check clang binary name, as it can be different in some test setups.
ClosedPublic

Authored by alexfh on Jun 26 2014, 9:51 AM.

Diff Detail

Event Timeline

alexfh updated this revision to Diff 10891.Jun 26 2014, 9:51 AM
alexfh retitled this revision from to Don't check clang binary name, as it can be different in some test setups..
alexfh updated this object.
alexfh edited the test plan for this revision. (Show Details)
alexfh added a reviewer: chandlerc.
alexfh added a subscriber: Unknown Object (MLST).

We have these kinds of checks in a lot of the other Driver tests. Should we update those as well (in general, not necessarily for this patch)?

chandlerc accepted this revision.Jun 27 2014, 4:19 AM
chandlerc edited edge metadata.

LGTM, thanks Alex

This revision is now accepted and ready to land.Jun 27 2014, 4:19 AM

We have these kinds of checks in a lot of the other Driver tests. Should we update those as well (in general, not necessarily for this patch)?

We have to either specify -no-canonical-prefixes with each clang invocation in tests, or don't check clang binary name. Most of the tests do one of this things already, all the rest should do this. The tests are not consistent in choosing one of these options, so here I've chosen the simplest one.

alexfh closed this revision.Jun 27 2014, 4:26 AM