This is an archive of the discontinued LLVM Phabricator instance.

AArch64: use 32bit registers in ldr-pseudo.s tests
AbandonedPublic

Authored by jannau on Jun 24 2014, 2:42 PM.

Details

Reviewers
None
Summary

The constant pool used in r211605 for implementing the "ldr <reg>, =..." pseudo instruction uses only 32 bit constants.

Diff Detail

Event Timeline

jannau updated this revision to Diff 10804.Jun 24 2014, 2:42 PM
jannau retitled this revision from to AArch64: use 32bit registers in ldr-pseudo.s tests.
jannau updated this object.
jannau edited the test plan for this revision. (Show Details)
jannau added a project: deleted.
jannau added a subscriber: Unknown Object (MLST).

It's not clear to me how this change improves the test. Rather than just renaming, I think it would be better to

  1. Add tests for moving 32-bit constants to w registers
  2. Add tests for moving 64-bit constants to x registers
  3. Add tests for moving 64-bit constants to w registers (should produce an error).
jannau abandoned this revision.Jul 12 2014, 11:10 AM

I will change and squash this patch into http://reviews.llvm.org/D4279

I'm not sure if erroring for size mismatches is possible in all cases though.