Details
Details
- Reviewers
hans
Diff Detail
Diff Detail
Event Timeline
Comment Actions
The code itself looks good, but I'm not sure this is the right place.
include/llvm/Support/Program.h | ||
---|---|---|
156 | I'm not sure Program.h is the right place. This header seems mostly concerned with running programs. Perhaps Process.h, next to GetEnv() is a better place? Or maybe FileSystem.h? |
Comment Actions
I chose Program.h because I found FindProgramByName there... But I'm not sure if that's the best place either. Can you please suggest either Process.h or FileSystem.h? Either would work for me. :-)
Comment Actions
I chose Program.h because I found FindProgramByName there... But I'm not sure if that's the best place either. Can you please suggest either Process.h or FileSystem.h? Either would work for me. :-)
I feel this is tightly related to GetEnv, so let's go for Process.
I'm not sure Program.h is the right place. This header seems mostly concerned with running programs.
Perhaps Process.h, next to GetEnv() is a better place? Or maybe FileSystem.h?