Fixing tag in HandleLLVMOptions.cmake

[• javier]

Summary

This change fixes the tag in an else() statement contained in HandleLLVMOptions.cmake. The tag is currently LLVM_COMPILER_IS_GCC_COMPATIBLE but it should be MSVC.

[zturner]

I'm confused, why should this be MSVC? Wall -Wno-unused-parameter -Wwrite-strings are all GCC compiler options and are unrecognized by MSVC.

[• javier]

Yikes, I'm really sorry, even after re-reading that multiple times I didn't realize it was an elseif. My brain kept converting it to an else(). Give that observation the patch is obviously wrong and I'll retract it. Thanks zturner for reviewing.

[• javier]

I've been searching online and haven't found a way to cancel the review. If someone can point me to the steps I'll gladly do it.

[rnk]

In the 'Action' drop select box at the bottom you can choose 'Close
Revision' (perhaps this was previously 'Abandon Revision'?) and it should
go away.

[• javier]

Closing the revision

HandleLLVMOptions.cmake

   if (LLVM_ENABLE_WERROR)
     add_llvm_definitions( /WX )
   endif (LLVM_ENABLE_WERROR)
-elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )
+elseif( MSVC )
   if (LLVM_ENABLE_WARNINGS)
     append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)