This is an archive of the discontinued LLVM Phabricator instance.

R600: Implement ftrunc, ffloor and fceil.
ClosedPublic

Authored by arsenm on Jun 8 2014, 2:38 PM.

Details

Reviewers
arsenm
Summary

CI has instructions for these, so this fixes them for older hardware.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 10219.Jun 8 2014, 2:38 PM
arsenm retitled this revision from to R600: Implement ftrunc, ffloor and fceil..
arsenm updated this object.
arsenm edited the test plan for this revision. (Show Details)
arsenm added a subscriber: Unknown Object (MLST).
arsenm accepted this revision.Jun 18 2014, 10:14 AM
arsenm added a reviewer: arsenm.

r211183

This revision is now accepted and ready to land.Jun 18 2014, 10:14 AM
arsenm closed this revision.Jun 18 2014, 10:14 AM

This introduces some test failures on Windows building with MSVC 2013.
Here is the output.

  • Testing: 10974 tests, 32 threads --

FAIL: LLVM :: CodeGen/R600/fceil64.ll (2967 of 10974)

  • TEST 'LLVM :: CodeGen/R600/fceil64.ll' FAILED ****

Script:

D:/src/llvm/build/ninja/./bin\llc.EXE -march=r600 -mcpu=bonaire <
D:\src\llvm\test\CodeGen\R600\fceil64.ll |
D:/src/llvm/build/ninja/./bin\FileCheck.EXE -check-prefix=CI
-check-prefix=FUNC D:\src\llvm\test\CodeGen\R600\fceil64.ll
D:/src/llvm/build/ninja/./bin\llc.EXE -march=r600 -mcpu=SI <
D:\src\llvm\test\CodeGen\R600\fceil64.ll |
D:/src/llvm/build/ninja/./bin\FileCheck.EXE -check-prefix=SI

-check-prefix=FUNC D:\src\llvm\test\CodeGen\R600\fceil64.ll

Exit Code: 1

Command Output (stdout):

Command 0: "D:/src/llvm/build/ninja/./bin\llc.EXE" "-march=r600"
"-mcpu=bonaire"
Command 0 Result: 0
Command 0 Output:

Command 0 Stderr:

Command 1: "D:/src/llvm/build/ninja/./bin\FileCheck.EXE" "-check-prefix=CI"
"-check-prefix=FUNC" "D:\src\llvm\test\CodeGen\R600\fceil64.ll"
Command 1 Result: 0
Command 1 Output:

Command 1 Stderr:

Command 2: "D:/src/llvm/build/ninja/./bin\llc.EXE" "-march=r600" "-mcpu=SI"
Command 2 Result: 0
Command 2 Output:

Command 2 Stderr:

Command 3: "D:/src/llvm/build/ninja/./bin\FileCheck.EXE" "-check-prefix=SI"
"-check-prefix=FUNC" "D:\src\llvm\test\CodeGen\R600\fceil64.ll"
Command 3 Result: 1
Command 3 Output:

Command 3 Stderr:
D:\src\llvm\test\CodeGen\R600\fceil64.ll:15:7: error: expected string not
found in input
; SI: S_LSHR_B64

^

<stdin>:18:2: note: scanning from here
V_CMP_LT_I32_e64 s[10:11], s8, 0, 0, 0
^
<stdin>:19:9: note: possible intended match here
V_CNDMASK_B32_e64 v2, v0, v1, s[10:11], 0, 0, 0, 0

^

FAIL: LLVM :: CodeGen/R600/ffloor.ll (2988 of 10974)

  • TEST 'LLVM :: CodeGen/R600/ffloor.ll' FAILED ****

Script:

D:/src/llvm/build/ninja/./bin\llc.EXE -march=r600 -mcpu=bonaire <
D:\src\llvm\test\CodeGen\R600\ffloor.ll |
D:/src/llvm/build/ninja/./bin\FileCheck.EXE -check-prefix=CI
-check-prefix=FUNC D:\src\llvm\test\CodeGen\R600\ffloor.ll
D:/src/llvm/build/ninja/./bin\llc.EXE -march=r600 -mcpu=SI <
D:\src\llvm\test\CodeGen\R600\ffloor.ll |
D:/src/llvm/build/ninja/./bin\FileCheck.EXE -check-prefix=SI

-check-prefix=FUNC D:\src\llvm\test\CodeGen\R600\ffloor.ll

Exit Code: 1

Command Output (stdout):

Command 0: "D:/src/llvm/build/ninja/./bin\llc.EXE" "-march=r600"
"-mcpu=bonaire"
Command 0 Result: 0
Command 0 Output:

Command 0 Stderr:

Command 1: "D:/src/llvm/build/ninja/./bin\FileCheck.EXE" "-check-prefix=CI"
"-check-prefix=FUNC" "D:\src\llvm\test\CodeGen\R600\ffloor.ll"
Command 1 Result: 0
Command 1 Output:

Command 1 Stderr:

Command 2: "D:/src/llvm/build/ninja/./bin\llc.EXE" "-march=r600" "-mcpu=SI"
Command 2 Result: 0
Command 2 Output:

Command 2 Stderr:

Command 3: "D:/src/llvm/build/ninja/./bin\FileCheck.EXE" "-check-prefix=SI"
"-check-prefix=FUNC" "D:\src\llvm\test\CodeGen\R600\ffloor.ll"
Command 3 Result: 1
Command 3 Output:

Command 3 Stderr:
D:\src\llvm\test\CodeGen\R600\ffloor.ll:16:7: error: expected string not
found in input
; SI: S_LSHR_B64

^

<stdin>:18:2: note: scanning from here
V_CMP_LT_I32_e64 s[10:11], s8, 0, 0, 0
^
<stdin>:19:9: note: possible intended match here
V_CNDMASK_B32_e64 v2, v0, v1, s[10:11], 0, 0, 0, 0

^

FAIL: LLVM :: CodeGen/R600/ftrunc.ll (2994 of 10974)

  • TEST 'LLVM :: CodeGen/R600/ftrunc.ll' FAILED ****

Script:

D:/src/llvm/build/ninja/./bin\llc.EXE -march=r600 -mcpu=bonaire <
D:\src\llvm\test\CodeGen\R600\ftrunc.ll |
D:/src/llvm/build/ninja/./bin\FileCheck.EXE -check-prefix=CI
-check-prefix=FUNC D:\src\llvm\test\CodeGen\R600\ftrunc.ll
D:/src/llvm/build/ninja/./bin\llc.EXE -march=r600 -mcpu=SI <
D:\src\llvm\test\CodeGen\R600\ftrunc.ll |
D:/src/llvm/build/ninja/./bin\FileCheck.EXE -check-prefix=SI

-check-prefix=FUNC D:\src\llvm\test\CodeGen\R600\ftrunc.ll

Exit Code: 1

Command Output (stdout):

Command 0: "D:/src/llvm/build/ninja/./bin\llc.EXE" "-march=r600"
"-mcpu=bonaire"
Command 0 Result: 0
Command 0 Output:

Command 0 Stderr:

Command 1: "D:/src/llvm/build/ninja/./bin\FileCheck.EXE" "-check-prefix=CI"
"-check-prefix=FUNC" "D:\src\llvm\test\CodeGen\R600\ftrunc.ll"
Command 1 Result: 0
Command 1 Output:

Command 1 Stderr:

Command 2: "D:/src/llvm/build/ninja/./bin\llc.EXE" "-march=r600" "-mcpu=SI"
Command 2 Result: 0
Command 2 Output:

Command 2 Stderr:

Command 3: "D:/src/llvm/build/ninja/./bin\FileCheck.EXE" "-check-prefix=SI"
"-check-prefix=FUNC" "D:\src\llvm\test\CodeGen\R600\ftrunc.ll"
Command 3 Result: 1
Command 3 Output:

Command 3 Stderr:
D:\src\llvm\test\CodeGen\R600\ftrunc.ll:27:7: error: expected string not
found in input
; SI: S_LSHR_B64

^

<stdin>:58:2: note: scanning from here
V_CMP_LT_I32_e64 s[10:11], s8, 0, 0, 0
^
<stdin>:59:9: note: possible intended match here
V_CNDMASK_B32_e64 v1, v0, v1, s[10:11], 0, 0, 0, 0

^

Testing Time: 94.18s


Failing Tests (3):

LLVM :: CodeGen/R600/fceil64.ll
LLVM :: CodeGen/R600/ffloor.ll
LLVM :: CodeGen/R600/ftrunc.ll