This is an archive of the discontinued LLVM Phabricator instance.

Roundtrip the inalloca bit on allocas through bitcode
ClosedPublic

Authored by rnk on May 28 2014, 3:05 PM.

Details

Summary

This was an oversight in the original support. As it is, I stuffed this
bit into the alignment. The alignment is stored in log2 form, so it
doesn't need more than 6 bits. On the other hand, adding a separate
record might be cleaner. Hence, I'm asking for a review, since we can't
change the decision once we make it.

Diff Detail

Event Timeline

rnk updated this revision to Diff 9890.May 28 2014, 3:05 PM
rnk retitled this revision from to Roundtrip the inalloca bit on allocas through bitcode.
rnk updated this object.
rnk added reviewers: nicholas, nlewycky.
rnk added a subscriber: Unknown Object (MLST).
rnk updated this revision to Diff 11411.Jul 14 2014, 7:19 PM
  • Lower the alignment bar
nlewycky accepted this revision.Jul 15 2014, 6:13 PM
nlewycky edited edge metadata.

I'm surprised there isn't a "test all the features" round trip test for bitcode, but I couldn't find one.

This revision is now accepted and ready to land.Jul 15 2014, 6:13 PM
rnk closed this revision.Jul 15 2014, 6:43 PM
rnk updated this revision to Diff 11484.

Closed by commit rL213118 (authored by @rnk).