This is an archive of the discontinued LLVM Phabricator instance.

Disable exception handling for LLDB.
ClosedPublic

Authored by zturner on May 27 2014, 2:41 PM.

Details

Reviewers
tfiala
Summary

Disables exception handling in LLDB, using appropriate compiler
flags depending on the platform. This is consistent with the build
of LLVM, should improve performance, and also removes a substantial number
of warnings from the Windows build.

Diff Detail

Event Timeline

zturner updated this revision to Diff 9848.May 27 2014, 2:41 PM
zturner retitled this revision from to Disable exception handling for LLDB..
zturner updated this object.
zturner edited the test plan for this revision. (Show Details)
zturner added a subscriber: Unknown Object (MLST).
tfiala edited edge metadata.May 28 2014, 9:59 AM

Doing a test build now.

tfiala accepted this revision.May 28 2014, 10:11 AM
tfiala edited edge metadata.

LGTM. Built fine on Ubuntu 12.04 x86_64 cmake/ninja. All tests pass.
MacOSX Xcode build unaffected verified.

This revision is now accepted and ready to land.May 28 2014, 10:11 AM
tfiala closed this revision.May 28 2014, 10:13 AM

svn commit
Sending CMakeLists.txt
Transmitting file data .
Committed revision 209752.