This is an archive of the discontinued LLVM Phabricator instance.

[Graph Writer] Limit the length of the graph name because Windows can't handle it.
ClosedPublic

Authored by Bigcheese on May 22 2014, 4:24 PM.

Details

Summary

Windows can't handle paths longer than 260 code points without \\?\. Even
with \\?\ it can't handle path components longer than 255 code points. So
limit graph names to the arbitrary length of 140. Random characters are still
added to the end, so it's ok if graph names collide.

Diff Detail

Repository
rL LLVM

Event Timeline

Bigcheese updated this revision to Diff 9721.May 22 2014, 4:24 PM
Bigcheese retitled this revision from to [Graph Writer] Limit the length of the graph name because Windows can't handle it..
Bigcheese updated this object.
Bigcheese edited the test plan for this revision. (Show Details)
Bigcheese added reviewers: aaron.ballman, rnk.
Bigcheese added a subscriber: Unknown Object (MLST).May 22 2014, 4:26 PM

CCed llvm-commits.

rnk accepted this revision.May 22 2014, 4:28 PM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.May 22 2014, 4:28 PM
aaron.ballman edited edge metadata.May 22 2014, 4:30 PM

LGTM!

~Aaron

Bigcheese closed this revision.May 22 2014, 4:39 PM
Bigcheese updated this revision to Diff 9723.

Closed by commit rL209483 (authored by mspencer).