This is an archive of the discontinued LLVM Phabricator instance.

Extend sys::getHostCPUFeatures to work on AArch64 platforms
ClosedPublic

Authored by bsmith on May 22 2014, 3:29 AM.

Details

Reviewers
t.p.northover
Summary

This change extends the existing ARM version of the function sys::getHostCPUFeatures to correctly recognize the AArch64 kernel features. Unfortunately there is no testcase for this patch since I can't see how to reasonably write one (nor is this function used anywhere in the codebase), the result of any testcase for this would differ depending on what platform it was run on.

Diff Detail

Event Timeline

bsmith updated this revision to Diff 9688.May 22 2014, 3:29 AM
bsmith retitled this revision from to Extend sys::getHostCPUFeatures to work on AArch64 platforms.
bsmith updated this object.
bsmith edited the test plan for this revision. (Show Details)
bsmith set the repository for this revision to rL LLVM.
bsmith added a subscriber: Unknown Object (MLST).

Hi Bradley,

Just one comment here:

lib/Support/Host.cpp
719–723

Could we have a local enum for this?

bsmith updated this revision to Diff 9689.May 22 2014, 4:20 AM

Update patch to use a local enum in place of hardcoded bit values.

t.p.northover accepted this revision.May 22 2014, 4:42 AM
t.p.northover added a reviewer: t.p.northover.

Thanks Bradley. This looks fine now.

Tim.

This revision is now accepted and ready to land.May 22 2014, 4:42 AM
bsmith closed this revision.May 22 2014, 4:53 AM