This is an archive of the discontinued LLVM Phabricator instance.

XFAIL ptrace test on arm
ClosedPublic

Authored by garious on May 20 2014, 3:21 PM.

Details

Summary

The patch adds better target_triple and target_arch defaults for lit tests,
which allows us to XFAIL tests based on architecture.

Was:

target_triple = LLVM_DEFAULT_TARGET_TRIPLE
target_arch = HOST_ARCH

Now:

target_triple = COMPILER_RT_TEST_TARGET_TRIPLE
              , otherwise LLVM_DEFAULT_TARGET_TRIPLE
target_arch = first item in COMPILER_RT_TEST_TARGET_TRIPLE

Diff Detail

Event Timeline

garious updated this revision to Diff 9644.May 20 2014, 3:21 PM
garious retitled this revision from to XFAIL ptrace test on arm .
garious updated this object.
garious edited the test plan for this revision. (Show Details)
garious added reviewers: samsonov, kcc.
garious added a subscriber: Unknown Object (MLST).
samsonov edited edge metadata.May 20 2014, 3:32 PM

Shouldn't this be called COMPILER_RT_TEST_TARGET_TRIPLE instead?

test/lit.common.configured.in
10

Is this actually used anywhere?

samsonov added inline comments.May 20 2014, 3:39 PM
test/lit.common.configured.in
10

Ah, disregard this comment. lit uses it to properly understand XFAIL.

Shouldn't this be called COMPILER_RT_TEST_TARGET_TRIPLE instead?

Would you prefer I add '_TEST' here? If *_COMPILER_ID==Clang, it's safe to use this value for the -target flag as well. This variable could be a convenient way to mix and match GCC and Clang. We could remove -target from CMAKE_C_FLAGS and COMPILER_RT_TEST_CFLAGS and then automatically add it in whenever *_COMPILER_ID==Clang.

COMPILER_RT_TARGET_TRIPLE can be confusing at the moment: we're building compiler-rt *libraries* for several targets (e.g. both for x86_64 and i386).

garious updated this revision to Diff 9646.May 20 2014, 4:09 PM
garious updated this object.
garious edited edge metadata.

Renamed COMPILER_RT_TARGET_TRIPLE to COMPILER_RT_TEST_TARGET_TRIPLE

samsonov accepted this revision.May 20 2014, 4:30 PM
samsonov edited edge metadata.

LGTM

CMakeLists.txt
144

COMPILER_RT_TEST_TARGET_ARCH here as well.

This revision is now accepted and ready to land.May 20 2014, 4:30 PM
garious closed this revision.May 20 2014, 4:39 PM
garious updated this revision to Diff 9647.

Closed by commit rL209256 (authored by @garious).