This is an archive of the discontinued LLVM Phabricator instance.

[ARM64] Port basic-a64-diagnostics.s over to ARM64
ClosedPublic

Authored by bsmith on May 20 2014, 4:45 AM.

Details

Reviewers
t.p.northover
Summary

This patch makes the necessary changes to basic-a64-diagnostics.s to get it to pass successfully on ARM64. It's worth noting that this patch completely disregards load/store diagnostics since they are fundamentally broken due to already discussed issues, these should be fixed up after the merge. Other than that there are only minor differences in diagnostics emitted/what is diagnosed.

Diff Detail

Event Timeline

bsmith updated this revision to Diff 9610.May 20 2014, 4:45 AM
bsmith retitled this revision from to [ARM64] Port basic-a64-diagnostics.s over to ARM64.
bsmith updated this object.
bsmith edited the test plan for this revision. (Show Details)
bsmith added a reviewer: t.p.northover.
bsmith set the repository for this revision to rL LLVM.
bsmith added a subscriber: Unknown Object (MLST).
t.p.northover accepted this revision.May 20 2014, 5:03 AM
t.p.northover edited edge metadata.

Hi Bradley,

This looks reasonable to me.

Cheers.

Tim.

This revision is now accepted and ready to land.May 20 2014, 5:03 AM
bsmith closed this revision.May 20 2014, 6:41 AM