This is an archive of the discontinued LLVM Phabricator instance.

[asan] Move __asan_handle_no_return to public header
ClosedPublic

Authored by mcgrathr on Aug 16 2017, 5:37 PM.

Details

Summary

Heretofore asan_handle_no_return was used only by interceptors,
i.e. code private to the ASan runtime. However, on systems without
interceptors, code like libc++abi is built with -fsanitize=address
itself and should call
asan_handle_no_return directly from
__cxa_throw so that no interceptor is required.

Diff Detail

Repository
rL LLVM

Event Timeline

mcgrathr created this revision.Aug 16 2017, 5:37 PM
mcgrathr added a project: Restricted Project.Aug 16 2017, 5:37 PM
mcgrathr added a subscriber: phosek.

This is necessary for D36599 to (re-)land.

mcgrathr updated this revision to Diff 111442.Aug 16 2017, 5:43 PM
vitalybuka requested changes to this revision.Aug 16 2017, 5:47 PM

As now it's going to be apart of API, please add a test

This revision now requires changes to proceed.Aug 16 2017, 5:47 PM
mcgrathr updated this revision to Diff 112809.Aug 27 2017, 1:34 AM
mcgrathr edited edge metadata.

Added test case.

As now it's going to be apart of API, please add a test

Done.

vitalybuka accepted this revision.Aug 27 2017, 10:46 AM

Thank you!

This revision is now accepted and ready to land.Aug 27 2017, 10:46 AM
This revision was automatically updated to reflect the committed changes.