This is an archive of the discontinued LLVM Phabricator instance.

[PPC] Add Defs = [CARRY] to MIR SRADI_32
ClosedPublic

Authored by Carrot on Jul 20 2017, 2:07 PM.

Details

Summary

MIR SRADI uses instruction template XSForm_1rc which declares Defs = [CARRY]. But MIR SRADI_32 uses instruction template XSForm_1, and it doesn't declare such implicit definition. With patch D33720 it causes wrong code generation for perl.

This patch adds the implicit definition.

Diff Detail

Repository
rL LLVM

Event Timeline

Carrot created this revision.Jul 20 2017, 2:07 PM
nemanjai accepted this revision.Jul 20 2017, 9:58 PM

Carrot, thank you so much for working on this and I'm really sorry for the omission when we defined the instruction. This implicit def certainly needs to be set on the instruction.

LGTM.

This revision is now accepted and ready to land.Jul 20 2017, 9:58 PM
echristo accepted this revision.Jul 21 2017, 1:22 PM
This revision was automatically updated to reflect the committed changes.