This is an archive of the discontinued LLVM Phabricator instance.

Address warnings in EmulateInstructionARM64
ClosedPublic

Authored by emaste on Apr 28 2014, 7:04 AM.

Reviewers

Commits

Summary

emaste retitled this revision from to Address warnings in EmulateInstructionARM64.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a subscriber: Unknown Object (MLST).

Leave LSL_C in, hidden under #if 0, per Greg's request.
This file is using llvm::SignExtend64 already, so no need to keep our own copy of that.

emaste added a reviewer: emaste.

This revision is now accepted and ready to land.Apr 28 2014, 2:43 PM

r207449

Path

Size

source/

Plugins/

Instruction/

ARM64/

3 lines

10 lines

Show All 40 Lines	SupportsEmulatingInstructionsOfTypeStatic (lldb_private::InstructionType inst_type)
{		{
case lldb_private::eInstructionTypeAny:		case lldb_private::eInstructionTypeAny:
case lldb_private::eInstructionTypePrologueEpilogue:		case lldb_private::eInstructionTypePrologueEpilogue:
return true;		return true;

case lldb_private::eInstructionTypePCModifying:		case lldb_private::eInstructionTypePCModifying:
case lldb_private::eInstructionTypeAll:		case lldb_private::eInstructionTypeAll:
return false;		return false;

default:
break;
}		}
return false;		return false;
}		}

virtual lldb_private::ConstString		virtual lldb_private::ConstString
GetPluginName();		GetPluginName();

virtual lldb_private::ConstString		virtual lldb_private::ConstString
▲ Show 20 Lines • Show All 241 Lines • Show Last 20 Lines

	Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
	}			}

	static inline uint64_t			static inline uint64_t
	NOT(uint64_t x)			NOT(uint64_t x)
	{			{
	return ~x;			return ~x;
	}			}

				#if 0
	static inline int64_t
	SignExtend64(uint64_t x, uint32_t msbit)
	{
	return int64_t(x << (64 - msbit)) >> (64 - msbit);
	}


	// LSL_C()			// LSL_C()
	// =======			// =======
	static inline uint64_t			static inline uint64_t
	LSL_C (uint64_t x, integer shift, bool &carry_out)			LSL_C (uint64_t x, integer shift, bool &carry_out)
	{			{
	assert (shift >= 0);			assert (shift >= 0);
	uint64_t result = x << shift;			uint64_t result = x << shift;
	carry_out = ((1ull << (64-1)) >> (shift - 1)) != 0;			carry_out = ((1ull << (64-1)) >> (shift - 1)) != 0;
	return result;			return result;
	}			}
				#endif

	// LSL()			// LSL()
	// =====			// =====

	static inline uint64_t			static inline uint64_t
	LSL(uint64_t x, integer shift)			LSL(uint64_t x, integer shift)
	{			{
	if (shift == 0)			if (shift == 0)
	▲ Show 20 Lines • Show All 636 Lines • Show Last 20 Lines