This is an archive of the discontinued LLVM Phabricator instance.

[ARM64] Print preferred aliases for SFBM/UBFM in InstPrinter
ClosedPublic

Authored by bsmith on Apr 25 2014, 2:23 AM.

Details

Reviewers
t.p.northover
Summary

The ARM64 InstPrinter does not print the preferred form of SBFM/UBFM instructions, this patch fixes this such that SBFIZ/SBFX/SXTB etc are instead printed where preferred. Additionally 64-bit variants of UXTB/H/W should never be printed since they are not part of the architecture, but rather a logical extension of the aliases.

Diff Detail

Event Timeline

bsmith updated this revision to Diff 8833.Apr 25 2014, 2:23 AM
bsmith retitled this revision from to [ARM64] Print preferred aliases for SFBM/UBFM in InstPrinter.
bsmith updated this object.
bsmith edited the test plan for this revision. (Show Details)
bsmith added a reviewer: t.p.northover.
bsmith set the repository for this revision to rL LLVM.
bsmith added a subscriber: Unknown Object (MLST).
t.p.northover edited edge metadata.Apr 25 2014, 2:58 AM

Hi Bradley,

This looks reasonable as a stopgap. The BFM assembly hacks are all fairly nasty though; I'm hoping to remove them soon.

Cheers.

Tim.

t.p.northover accepted this revision.Apr 25 2014, 2:58 AM
t.p.northover edited edge metadata.
This revision is now accepted and ready to land.Apr 25 2014, 2:58 AM
bsmith closed this revision.Apr 25 2014, 3:34 AM