This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: remove use of @llvm.arm.sevl
ClosedPublic

Authored by abdulras on Apr 24 2014, 4:06 PM.

Download Raw Diff

Details

Reviewers

t.p.northover
abdulras

Summary

Remove use of the @llvm.arm.sevl intrinsic in favour of the new @llvm.arm.hint
intrinsic.

Depends on http://reviews.llvm.org/D3492.

Diff Detail

Event Timeline

abdulras updated this revision to Diff 8821.Apr 24 2014, 4:06 PM

abdulras retitled this revision from to CodeGen: remove use of @llvm.arm.sevl.

abdulras updated this object.

abdulras edited the test plan for this revision. (Show Details)

abdulras added a reviewer: t.p.northover.

abdulras set the repository for this revision to rL LLVM.

abdulras added a subscriber: Unknown Object (MLST).

Herald added a subscriber: aemerson. · View Herald TranscriptApr 24 2014, 4:06 PM

LGTM.

Committed as SVN r207243.

This revision is now accepted and ready to land.Apr 25 2014, 10:34 AM

abdulras closed this revision.Apr 25 2014, 10:34 AM

Revision Contents

Path

Size

lib/

CodeGen/

CGBuiltin.cpp

4 lines

test/

CodeGen/

builtins-arm.c

2 lines

Diff 8821

lib/CodeGen/CGBuiltin.cpp

	Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
	}			}

	if (BuiltinID == ARM::BI__builtin_arm_clrex) {			if (BuiltinID == ARM::BI__builtin_arm_clrex) {
	Function *F = CGM.getIntrinsic(Intrinsic::arm_clrex);			Function *F = CGM.getIntrinsic(Intrinsic::arm_clrex);
	return Builder.CreateCall(F);			return Builder.CreateCall(F);
	}			}

	if (BuiltinID == ARM::BI__builtin_arm_sevl) {			if (BuiltinID == ARM::BI__builtin_arm_sevl) {
	Function *F = CGM.getIntrinsic(Intrinsic::arm_sevl);			Function *F = CGM.getIntrinsic(Intrinsic::arm_hint);
	return Builder.CreateCall(F);			return Builder.CreateCall(F, llvm::ConstantInt::get(Int32Ty, 5));
	}			}

	// CRC32			// CRC32
	Intrinsic::ID CRCIntrinsicID = Intrinsic::not_intrinsic;			Intrinsic::ID CRCIntrinsicID = Intrinsic::not_intrinsic;
	switch (BuiltinID) {			switch (BuiltinID) {
	case ARM::BI__builtin_arm_crc32b:			case ARM::BI__builtin_arm_crc32b:
	CRCIntrinsicID = Intrinsic::arm_crc32b; break;			CRCIntrinsicID = Intrinsic::arm_crc32b; break;
	case ARM::BI__builtin_arm_crc32cb:			case ARM::BI__builtin_arm_crc32cb:
	▲ Show 20 Lines • Show All 991 Lines • Show Last 20 Lines

test/CodeGen/builtins-arm.c

Show All 16 Lines	void test_eh_return_data_regno()
volatile int res;		volatile int res;
res = __builtin_eh_return_data_regno(0); // CHECK: store volatile i32 0		res = __builtin_eh_return_data_regno(0); // CHECK: store volatile i32 0
res = __builtin_eh_return_data_regno(1); // CHECK: store volatile i32 1		res = __builtin_eh_return_data_regno(1); // CHECK: store volatile i32 1
}		}

void sevl() {		void sevl() {
__builtin_arm_sevl();		__builtin_arm_sevl();
}		}
// CHECK: call {{.*}} @llvm.arm.sevl		// CHECK: call {{.*}} @llvm.arm.hint(i32 5)

void test_barrier() {		void test_barrier() {
__builtin_arm_dmb(1); //CHECK: call {{.*}} @llvm.arm.dmb(i32 1)		__builtin_arm_dmb(1); //CHECK: call {{.*}} @llvm.arm.dmb(i32 1)
__builtin_arm_dsb(2); //CHECK: call {{.*}} @llvm.arm.dsb(i32 2)		__builtin_arm_dsb(2); //CHECK: call {{.*}} @llvm.arm.dsb(i32 2)
}		}