This is an archive of the discontinued LLVM Phabricator instance.

Differential D31995

Enable LSan on PowerPC64.
ClosedPublic

Authored by alekseyshl on Apr 12 2017, 3:54 PM.

Details

Reviewers
eugenis
Commits
rGd77394c5f2ec: Enable LSan on PowerPC64.
rCRT300204: Enable LSan on PowerPC64.
rL300204: Enable LSan on PowerPC64.
Summary

With D31555 commited, looks like basic LSan functionality
works on PPC64. Time to enable LSan there.

Diff Detail

Revision Contents

PathSize
lib/
lsan/
2 lines
3 lines
test/
lsan/
4 lines

Diff 95046

lib/lsan/lsan_allocator.h

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines#if defined(__mips64) || defined(__aarch64__) || defined(__i386__) || \
defined(__arm__) defined(__arm__)
static const uptr kRegionSizeLog = 20; static const uptr kRegionSizeLog = 20;
static const uptr kNumRegions = SANITIZER_MMAP_RANGE_SIZE >> kRegionSizeLog; static const uptr kNumRegions = SANITIZER_MMAP_RANGE_SIZE >> kRegionSizeLog;
typedef TwoLevelByteMap<(kNumRegions >> 12), 1 << 12> ByteMap; typedef TwoLevelByteMap<(kNumRegions >> 12), 1 << 12> ByteMap;
typedef CompactSizeClassMap SizeClassMap; typedef CompactSizeClassMap SizeClassMap;
typedef SizeClassAllocator32<0, SANITIZER_MMAP_RANGE_SIZE, typedef SizeClassAllocator32<0, SANITIZER_MMAP_RANGE_SIZE,
sizeof(ChunkMetadata), SizeClassMap, kRegionSizeLog, ByteMap> sizeof(ChunkMetadata), SizeClassMap, kRegionSizeLog, ByteMap>
PrimaryAllocator; PrimaryAllocator;
#elif defined(__x86_64__) #elif defined(__x86_64__) || defined(__powerpc64__)
struct AP64 { // Allocator64 parameters. Deliberately using a short name. struct AP64 { // Allocator64 parameters. Deliberately using a short name.
static const uptr kSpaceBeg = 0x600000000000ULL; static const uptr kSpaceBeg = 0x600000000000ULL;
static const uptr kSpaceSize = 0x40000000000ULL; // 4T. static const uptr kSpaceSize = 0x40000000000ULL; // 4T.
static const uptr kMetadataSize = sizeof(ChunkMetadata); static const uptr kMetadataSize = sizeof(ChunkMetadata);
typedef DefaultSizeClassMap SizeClassMap; typedef DefaultSizeClassMap SizeClassMap;
typedef NoOpMapUnmapCallback MapUnmapCallback; typedef NoOpMapUnmapCallback MapUnmapCallback;
static const uptr kFlags = 0; static const uptr kFlags = 0;
}; };
Show All 18 Lines

lib/lsan/lsan_common.h

Show All 26 Lines
// because of "small" (4 bytes) pointer size that leads to high false negative // because of "small" (4 bytes) pointer size that leads to high false negative
// ratio on large leaks. But we still want to have it for some 32 bit arches // ratio on large leaks. But we still want to have it for some 32 bit arches
// (e.g. x86), see https://github.com/google/sanitizers/issues/403. // (e.g. x86), see https://github.com/google/sanitizers/issues/403.
// To enable LeakSanitizer on new architecture, one need to implement // To enable LeakSanitizer on new architecture, one need to implement
// internal_clone function as well as (probably) adjust TLS machinery for // internal_clone function as well as (probably) adjust TLS machinery for
// new architecture inside sanitizer library. // new architecture inside sanitizer library.
#if (SANITIZER_LINUX && !SANITIZER_ANDROID || SANITIZER_MAC) && \ #if (SANITIZER_LINUX && !SANITIZER_ANDROID || SANITIZER_MAC) && \
(SANITIZER_WORDSIZE == 64) && \ (SANITIZER_WORDSIZE == 64) && \
(defined(__x86_64__) || defined(__mips64) || defined(__aarch64__)) (defined(__x86_64__) || defined(__mips64) || defined(__aarch64__) || \
defined(__powerpc64__))
#define CAN_SANITIZE_LEAKS 1 #define CAN_SANITIZE_LEAKS 1
#elif defined(__i386__) && \ #elif defined(__i386__) && \
(SANITIZER_LINUX && !SANITIZER_ANDROID || SANITIZER_MAC) (SANITIZER_LINUX && !SANITIZER_ANDROID || SANITIZER_MAC)
#define CAN_SANITIZE_LEAKS 1 #define CAN_SANITIZE_LEAKS 1
#elif defined(__arm__) && \ #elif defined(__arm__) && \
SANITIZER_LINUX && !SANITIZER_ANDROID SANITIZER_LINUX && !SANITIZER_ANDROID
#define CAN_SANITIZE_LEAKS 1 #define CAN_SANITIZE_LEAKS 1
#else #else
▲ Show 20 Lines • Show All 195 Lines • Show Last 20 Lines

test/lsan/lit.common.cfg

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
def build_invocation(compile_flags): def build_invocation(compile_flags):
return " " + " ".join([config.clang] + compile_flags) + " " return " " + " ".join([config.clang] + compile_flags) + " "
config.substitutions.append( ("%clang ", build_invocation(clang_cflags)) ) config.substitutions.append( ("%clang ", build_invocation(clang_cflags)) )
config.substitutions.append( ("%clangxx ", build_invocation(clang_cxxflags)) ) config.substitutions.append( ("%clangxx ", build_invocation(clang_cxxflags)) )
config.substitutions.append( ("%clang_lsan ", build_invocation(clang_lsan_cflags)) ) config.substitutions.append( ("%clang_lsan ", build_invocation(clang_lsan_cflags)) )
config.substitutions.append( ("%clangxx_lsan ", build_invocation(clang_lsan_cxxflags)) ) config.substitutions.append( ("%clangxx_lsan ", build_invocation(clang_lsan_cxxflags)) )
# LeakSanitizer tests are currently supported on x86-64 Linux, arm Linux and mips64 Linux only. # LeakSanitizer tests are currently supported on x86-64 Linux, PowerPC64 Linux, arm Linux and mips64 Linux only.
# LSAN breaks on Thumb, so disabling from all ARM targets until we sort this out. PR32636. # LSAN breaks on Thumb, so disabling from all ARM targets until we sort this out. PR32636.
if config.host_os not in ['Linux'] or config.host_arch not in ['x86_64', 'mips64']: if config.host_os not in ['Linux'] or config.host_arch not in ['x86_64', 'mips64', 'ppc64']:
config.unsupported = True config.unsupported = True
# Don't support Thumb due to broken fast unwinder # Don't support Thumb due to broken fast unwinder
if re.match('-mthumb', config.target_cflags): if re.match('-mthumb', config.target_cflags):
config.unsupported = True config.unsupported = True
config.suffixes = ['.c', '.cc', '.cpp'] config.suffixes = ['.c', '.cc', '.cpp']