Hi all,
This patch implements the function argument passing for ARM big endian targets.
Please review.
Thanks,
Christian
Paths
| Differential D3193
ARM big endian function argument passing ClosedPublic Authored by cpirker on Mar 26 2014, 12:38 PM.
Details
Summary Hi all, This patch implements the function argument passing for ARM big endian targets. Thanks,
Diff Detail Event TimelineComment Actions Hi Christian, Wow, loads of similar changes! ;) They look harmless enough for me, but I'd be curious on what kind of testing have you done. I'm not worried with the changes themselves, but if you forgot something that wasn't being tested by make checks. Did you run the test-suite? What kind of big-endian hardware is it? Or was it a model? cheers, Comment Actions Hi Renato, we use a proprietary test suite and a vendor provided fast model for ARMv8 to perform testing. Thanks, Comment Actions ARMv8? This sounds like the wrong back-end, then. Shouldn't you be changing the AArch64 (or the ARM64) back-end? Also, if this is a proprietary test suite, at least you can tell us what kind of tests it does and how does that give you confidence that the changes are correct. Comment Actions Hi Renato, I think that should be ok, because I am referring to the armv8 in AArch32 mode which is supported by the ARM target. Our test suite uses a collection of often used code constructs and a collection of unit tests originally used for other compilers. Thanks, Comment Actions Hi all, I updated the patch because of the new behaviour for expand atomic ldrex/strex loops in IR. Thanks, Comment Actions Hi Renato, Test suite have been run with GNU libraries in little and big endian. Thanks, This revision is now accepted and ready to land.May 15 2014, 6:29 AM
Revision Contents
Diff 8913 lib/Target/ARM/ARMISelLowering.cpp
test/CodeGen/ARM/atomic-64bit.ll
test/CodeGen/ARM/atomic-ops-v8.ll
test/CodeGen/ARM/dagcombine-concatvector.ll
test/CodeGen/ARM/func-argpassing-endian.ll
test/CodeGen/ARM/longMAC.ll
test/CodeGen/ARM/long_shift.ll
test/CodeGen/ARM/sub.ll
test/CodeGen/ARM/vcombine.ll
|