Page MenuHomePhabricator

[Bugpoint] Erase comdat annotat after setting linkage to external.
Needs ReviewPublic

Authored by bryant on Apr 4 2017, 4:22 PM.

Details

Summary

Not entirely sure whether this is correct. I was unable to use Bugpoint to debug a miscompilation because its function splitting phase caused many verifier errors of this type: "Declaration may not be in a Comdat!" This patch resolved the issue.

This is similar in spirit to https://reviews.llvm.org/D21274 .

Diff Detail

Repository
rL LLVM

Event Timeline

bryant created this revision.Apr 4 2017, 4:22 PM
rnk edited edge metadata.Apr 4 2017, 4:30 PM

Why not do this in or after DeleteFunctionBody? That's when it becomes a declaration.