This is an archive of the discontinued LLVM Phabricator instance.

gtest: allow gtest compiling on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Jan 27 2014, 2:00 PM.

Details

Summary

This patch allows gtest on FreeBSD platforms (9.x).

Diff Detail

Event Timeline

I don't see a problem with this patch.

Please add a line to utils/unittest/googletest/README.LLVM with short change description.

utils/unittest/googletest/include/gtest/internal/gtest-port.h
91

Please put this line after GTEST_OS_CYGWIN to keep the list sorted.

kutuzov.viktor.84 updated this revision to Unknown Object (????).Feb 18 2014, 8:57 AM

Fixed.
Thanks.

samsonov accepted this revision.Feb 19 2014, 2:52 AM

LGTM. Let me know if I should commit this for you.

Please do. Thanks.

Submitted as r201683.

emaste added inline comments.Feb 24 2014, 8:16 AM
utils/unittest/googletest/include/gtest/internal/gtest-port.h
232

Can we get these changes into the upstream GTest repo?