Find clang resource directory via *nix-style lookup

[beanz]

Summary

This patch allows the Darwin build to fall back to to Posix-style lookups for the clang resource directory if the debugger library isn't inside a framework.

The patch also includes a bit of refactoring and cleanup around the *nix resolution of the binary and lib directories to reuse the code instead of duplicating it.

With this patch Darwin builds that don't build a framework only have 3 failing tests on my system (TestExec.py).

[tfiala]

Looks reasonable.

source/Host/macosx/HostInfoMacOSX.mm

235–239 ↗

(On Diff #76496)

We should have a const in place of the two uses of "LLDB.framework", but that can be a separate cleanup.

[labath]

looks good in general, but please check whether this is correct with LLVM_LIBDIR_SUFFIX=64.

source/Host/posix/HostInfoPosix.cpp

176 ↗

(On Diff #76496)

I think you need to include the LLVM_LIBDIR_SUFFIX here. At least that's what the usage of this directory in source/API/CMakeLists.txt leads me to believe.

lldb/trunk/include/lldb/Host/posix/HostInfoPosix.h

public:
   static FileSpec GetDefaultShell();
 
   static bool GetEnvironmentVar(const std::string &var_name, std::string &var);
 
 protected:
   static bool ComputeSupportExeDirectory(FileSpec &file_spec);
   static bool ComputeHeaderDirectory(FileSpec &file_spec);
   static bool ComputePythonDirectory(FileSpec &file_spec);
+  static bool ComputeClangDirectory(FileSpec &file_spec);
+  static bool ComputePathRelativeToLibrary(FileSpec &file_spec,
+                                           llvm::StringRef dir);
 };
 }
 
 #endif

lldb/trunk/source/Host/macosx/HostInfoMacOSX.mm

 bool HostInfoMacOSX::ComputeClangDirectory(FileSpec &file_spec) {
   FileSpec lldb_file_spec;
   if (!GetLLDBPath(lldb::ePathTypeLLDBShlibDir, lldb_file_spec))
     return false;
 
   std::string raw_path = lldb_file_spec.GetPath();
 
   size_t framework_pos = raw_path.find("LLDB.framework");
-  if (framework_pos != std::string::npos) {
-    framework_pos += strlen("LLDB.framework");
-    raw_path.resize(framework_pos);
-    raw_path.append("/Resources/Clang");
-  }
+  if (framework_pos == std::string::npos)
+    return HostInfoPosix::ComputeClangDirectory(file_spec);
+  
+  
   file_spec.SetFile(raw_path.c_str(), true);
   return true;
 }
 
 bool HostInfoMacOSX::ComputeSystemPluginsDirectory(FileSpec &file_spec) {
   FileSpec lldb_file_spec;
   if (!GetLLDBPath(lldb::ePathTypeLLDBShlibDir, lldb_file_spec))
     return false;

lldb/trunk/source/Host/posix/HostInfoPosix.cpp

 //===-- HostInfoPosix.cpp ---------------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #if !defined(LLDB_DISABLE_PYTHON)
 #include "Plugins/ScriptInterpreter/Python/lldb-python.h"
 #endif
 
 #include "lldb/Core/Log.h"
 #include "lldb/Host/posix/HostInfoPosix.h"
 
+#include "clang/Basic/Version.h"
+#include "clang/Config/config.h"
 #include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/Twine.h"
+#include "llvm/Support/Path.h"
 #include "llvm/Support/raw_ostream.h"
 
 #include <grp.h>
 #include <limits.h>
 #include <mutex>
 #include <netdb.h>
 #include <pwd.h>
 #include <stdlib.h>

 uint32_t HostInfoPosix::GetGroupID() { return getgid(); }
 
 uint32_t HostInfoPosix::GetEffectiveUserID() { return geteuid(); }
 
 uint32_t HostInfoPosix::GetEffectiveGroupID() { return getegid(); }
 
 FileSpec HostInfoPosix::GetDefaultShell() { return FileSpec("/bin/sh", false); }
 
-bool HostInfoPosix::ComputeSupportExeDirectory(FileSpec &file_spec) {
+bool HostInfoPosix::ComputePathRelativeToLibrary(FileSpec &file_spec,
+                                                 llvm::StringRef dir) {
   Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST);
 
   FileSpec lldb_file_spec;
   if (!GetLLDBPath(lldb::ePathTypeLLDBShlibDir, lldb_file_spec))
     return false;
 
-  char raw_path[PATH_MAX];
-  lldb_file_spec.GetPath(raw_path, sizeof(raw_path));
+  std::string raw_path = lldb_file_spec.GetPath();
+  // drop library directory
+  llvm::StringRef parent_path = llvm::sys::path::parent_path(raw_path);
 
   // Most Posix systems (e.g. Linux/*BSD) will attempt to replace a */lib with
-  // */bin as the base
-  // directory for helper exe programs.  This will fail if the /lib and /bin
-  // directories are
-  // rooted in entirely different trees.
+  // */bin as the base directory for helper exe programs.  This will fail if the
+  // /lib and /bin directories are rooted in entirely different trees.
   if (log)
-    log->Printf("HostInfoPosix::ComputeSupportExeDirectory() attempting to "
-                "derive the bin path (ePathTypeSupportExecutableDir) from "
-                "this path: %s",
-                raw_path);
-  char *lib_pos = ::strstr(raw_path, "/lib");
-  if (lib_pos != nullptr) {
+    log->Printf("HostInfoPosix::ComputePathRelativeToLibrary() attempting to "
+                "derive the %s path from this path: %s",
+                dir.data(), raw_path.c_str());
+
+  if (!parent_path.empty()) {
     // Now write in bin in place of lib.
-    ::snprintf(lib_pos, PATH_MAX - (lib_pos - raw_path), "/bin");
+    raw_path = (parent_path + dir).str();
 
     if (log)
       log->Printf("Host::%s() derived the bin path as: %s", __FUNCTION__,
-                  raw_path);
+                  raw_path.c_str());
   } else {
     if (log)
       log->Printf("Host::%s() failed to find /lib/liblldb within the shared "
                   "lib path, bailing on bin path construction",
                   __FUNCTION__);
   }
-  file_spec.GetDirectory().SetCString(raw_path);
+  file_spec.GetDirectory().SetString(raw_path);
   return (bool)file_spec.GetDirectory();
 }
 
+bool HostInfoPosix::ComputeSupportExeDirectory(FileSpec &file_spec) {
+  return ComputePathRelativeToLibrary(file_spec, "/bin");
+}
+
+bool HostInfoPosix::ComputeClangDirectory(FileSpec &file_spec) {
+  return ComputePathRelativeToLibrary(
+      file_spec, (llvm::Twine("/lib") + CLANG_LIBDIR_SUFFIX + "/clang/" +
+                  CLANG_VERSION_STRING)
+                     .str());
+}
+
 bool HostInfoPosix::ComputeHeaderDirectory(FileSpec &file_spec) {
   FileSpec temp_file("/opt/local/include/lldb", false);
   file_spec.GetDirectory().SetCString(temp_file.GetPath().c_str());
   return true;
 }
 
 bool HostInfoPosix::ComputePythonDirectory(FileSpec &file_spec) {
 #ifndef LLDB_DISABLE_PYTHON