This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Assign cost of scaling for Cortex-R52
ClosedPublic

Authored by javed.absar on Oct 17 2016, 5:52 AM.

Details

Summary

This patch assigns cost of the scaling used in addressing for Cortex-R52.

On Cortex-R52 a negated register offset takes longer than a non-negated register offset, in a register-offset addressing mode.

Diff Detail

Repository
rL LLVM

Event Timeline

javed.absar retitled this revision from to [ARM] Assign cost of scaling for Cortex-R52.
javed.absar updated this object.
javed.absar added reviewers: rengolin, jmolloy.
javed.absar added a subscriber: llvm-commits.
jmolloy requested changes to this revision.Oct 17 2016, 6:00 AM
jmolloy edited edge metadata.

Please provide patches with full context.

The test looks like it's duplicating checks for no good reason - It looks like we could simply have one check - CHECK-NONEGOFF. Then the three runs, A53, A57 and R52 would all use that same check.

The .td change looks fine.

This revision now requires changes to proceed.Oct 17 2016, 6:00 AM
javed.absar edited edge metadata.

Hi James:
Have revised the test based on your suggestions. Please have a look if it is alright for you now.
Best Regards
Javed

jmolloy accepted this revision.Oct 17 2016, 9:27 AM
jmolloy edited edge metadata.

LGTM, cheers!

This revision is now accepted and ready to land.Oct 17 2016, 9:27 AM
This revision was automatically updated to reflect the committed changes.