This is an archive of the discontinued LLVM Phabricator instance.

[safestack] Move tests into X86 subdirectory
ClosedPublic

Authored by mlemay-intel on Oct 6 2016, 11:58 AM.

Details

Summary

None of the tests in the base SafeStack directory specifies a non-X86
target. Running them even for builds lacking support for X86 targets
can result in spurious failures. For example, a proposed patch
requires that a target machine object be provided to the SafeStack
pass. Otherwise, it reports a fatal error.

This patch moves the tests from the base SafeStack directory into the
X86 subdirectory so that they will only be invoked when X86 targets
are supported.

Diff Detail

Repository
rL LLVM

Event Timeline

mlemay-intel retitled this revision from to [safestack] Move tests into X86 subdirectory.
mlemay-intel updated this object.
mlemay-intel added reviewers: eugenis, pcc.
pcc accepted this revision.Oct 6 2016, 12:04 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 6 2016, 12:04 PM

@pcc @andrew.w.kaylor: Can you please both confirm whether this patch is still acceptable as a short term solution for the build issue discussed in D24896?

pcc added a comment.Oct 10 2016, 12:13 PM

Still looks good

This revision was automatically updated to reflect the committed changes.
llvm/trunk/test/Transforms/SafeStack/phi.ll