This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Assembler: match e32 VOP instruction before e64.
ClosedPublic

Authored by SamWot on Sep 6 2016, 4:48 AM.

Details

Summary

Split assembler match table in 4 tables with assembler variants:

  • Default - all instructions except VOP3, SDWA and DPP
  • VOP3
  • SDWA
  • DPP

First match Default table then VOP3, SDWA and DPP.

Depends on D24249

Diff Detail

Event Timeline

SamWot updated this revision to Diff 70385.Sep 6 2016, 4:48 AM
SamWot retitled this revision from to [AMDGPU] Assembler: match e32 VOP instruction before e64..
SamWot updated this object.
SamWot added a subscriber: Restricted Project.
tstellarAMD accepted this revision.Sep 6 2016, 6:32 AM
tstellarAMD edited edge metadata.

This is a very nice solution for this problem. LGTM.

This revision is now accepted and ready to land.Sep 6 2016, 6:32 AM
artem.tamazov accepted this revision.Sep 6 2016, 6:41 AM
artem.tamazov edited edge metadata.

Good.

vpykhtin accepted this revision.Sep 8 2016, 7:06 AM
vpykhtin edited edge metadata.

LGTM.

This revision was automatically updated to reflect the committed changes.