This is an archive of the discontinued LLVM Phabricator instance.

PeepholeOptimizer: Relax assert
ClosedPublic

Authored by arsenm on Jun 29 2016, 5:20 PM.

Reviewers

qcolombet

Summary

Allow implicit defs

arsenm retitled this revision from to PeepholeOptimizer: Relax assert.

arsenm updated this object.

arsenm added a reviewer: qcolombet.

arsenm added a subscriber: llvm-commits.

Good catch Matt!

LGTM modulo, I would expect a test case for that.

Cheers,
-Quentin

In D21881#471775, @qcolombet wrote:

Good catch Matt!

LGTM modulo, I would expect a test case for that.

Cheers,
-Quentin

This will be hit in a future patch

Works for me.

Thanks!
Q.

This revision is now accepted and ready to land.Jul 1 2016, 3:54 PM

r274402

Path

Size

lib/

CodeGen/

6 lines

Show First 20 Lines • Show All 1,883 Lines • ▼ Show 20 Lines	ValueTrackerResult ValueTracker::getNextSourceFromPHI() {

return Res;		return Res;
}		}

ValueTrackerResult ValueTracker::getNextSourceImpl() {		ValueTrackerResult ValueTracker::getNextSourceImpl() {
assert(Def && "This method needs a valid definition");		assert(Def && "This method needs a valid definition");

assert(		assert(
(DefIdx < Def->getDesc().getNumDefs() \|\| Def->getDesc().isVariadic()) &&		(Def->getOperand(DefIdx).isDef() &&
Def->getOperand(DefIdx).isDef() && "Invalid DefIdx");		(DefIdx < Def->getDesc().getNumDefs() \|\| Def->getDesc().isVariadic()) \|\|
		Def->getOperand(DefIdx).isImplicit()) &&
		"Invalid DefIdx");
if (Def->isCopy())		if (Def->isCopy())
return getNextSourceFromCopy();		return getNextSourceFromCopy();
if (Def->isBitcast())		if (Def->isBitcast())
return getNextSourceFromBitcast();		return getNextSourceFromBitcast();
// All the remaining cases involve "complex" instructions.		// All the remaining cases involve "complex" instructions.
// Bail if we did not ask for the advanced tracking.		// Bail if we did not ask for the advanced tracking.
if (!UseAdvancedTracking)		if (!UseAdvancedTracking)
return ValueTrackerResult();		return ValueTrackerResult();
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines