This is an archive of the discontinued LLVM Phabricator instance.

[profile] Enable on SystemZ.
ClosedPublic

Authored by koriakin on Jun 26 2016, 2:20 PM.

Details

Summary

Depends on D21736, D21737. Once these are in, check-profile passes on SystemZ, so we can enable it.

Diff Detail

Repository
rL LLVM

Event Timeline

vsk accepted this revision.Jun 26 2016, 3:54 PM
vsk added a reviewer: vsk.
vsk added a subscriber: vsk.

This lgtm once the dependent patches are in.

As a heads-up: the gcov/SampleProf stuff has lower code coverage on big-endian systems due to xfails in test/tools/llvm-{cov,profdata} and in test/Transforms/SampleProfile. That should really be fixed. But, there's no sense in holding up this patch with that.

Before committing, please also check that building an instrumented stage2 clang on s390x works. I.e:

-DCMAKE_C_COMPILER=ToT/bin/clang -DCMAKE_CXX_COMPILER=ToT/bin/clang++ -DLLVM_PROFILE_DATA_DIR=/tmp -DLLVM_BUILD_INSTRUMENTED=On

This revision is now accepted and ready to land.Jun 26 2016, 3:54 PM
This revision was automatically updated to reflect the committed changes.