Don't run TestImageListMultiArchitecture during remote test suite

[fjricci]

This fix does not work without something along the lines of D21649, I'll re-upload with a better fix.

[fjricci]

Disconnect from existing platform connection to prevent extra hanging connections

This is good practice on all debug servers, and required for debug servers which
can't handle more than one simultaneous platform mode connection.

[tfiala]

Hi all,

If memory serves me correctly, I originally wrote this test. I don't think it buys us anything to run it against remote targets. I think a better approach here is to just exclude it when running against a remote.

We could instead use:

@decorator.skipIfRemote

[fjricci]

I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though.

[tfiala]

In D21648#466011, @fjricci wrote:

I was wondering that as well. I thought there might be some value to testing that the "disconnect->change platform->reconnect" path worked though. I have no problem disabling if that doesn't seem useful though.

I think that kind of test sounds good, but I would separate that into a test that is focused on that element rather than conflating it with this one.

If you can switch this over to skipping the test on remote systems (should be @decorators.skipIfRemote IIRC), that would be ideal.

[fjricci]

That's reasonable, will do.

[fjricci]

Skip test on remote platforms

[tfiala]

Thanks, looks good!

[clayborg]

Looks good.

lldb/trunk/packages/Python/lldbsuite/test/functionalities/object-file/TestImageListMultiArchitecture.py

 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 class TestImageListMultiArchitecture(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
     @no_debug_info_test
+    @skipIfRemote
     def test_image_list_shows_multiple_architectures(self):
         """Test that image list properly shows the correct architecture for a set of different architecture object files."""
         images = {
             "hello-freebsd-10.0-x86_64-clang-3.3": re.compile(r"x86_64-(\*)?-freebsd10.0(-unknown)? x86_64"),
             "hello-freebsd-10.0-x86_64-gcc-4.7.3": re.compile(r"x86_64-(\*)?-freebsd10.0(-unknown)? x86_64"),
             "hello-netbsd-6.1-x86_64-gcc-4.5.3": re.compile(r"x86_64-(\*)?-netbsd(-unknown)? x86_64"),
             "hello-ubuntu-14.04-x86_64-gcc-4.8.2": re.compile(r"x86_64-(\*)?-linux(-unknown)? x86_64"),
             "hello-ubuntu-14.04-x86_64-clang-3.5pre": re.compile(r"x86_64-(\*)?-linux(-unknown)? x86_64"),